Conversation
This reverts commit 096a291.
iboutle
marked this pull request as ready for review
September 9, 2026 08:16
iboutle
requested review from
a team and
Hacka Fett (christophermaynard)
as code owners
September 9, 2026 08:16
iboutle
requested review from
Mike Hobson (mike-hobson)
and removed request for
a team
September 9, 2026 08:16
Adrian Lock (Adrian-Lock)
left a comment
Contributor
There was a problem hiding this comment.
Really just a very minor question on one of the comments
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
Adrian Lock (Adrian-Lock)
approved these changes
Sep 9, 2026
Adrian Lock (Adrian-Lock)
left a comment
Contributor
There was a problem hiding this comment.
All fine now, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Adrian Lock (@Adrian-Lock)
Code Reviewer: allynt
Add diagnostics of large-scale and convective precipitation when using Comorph, which prognostically outputs all precipitation via the large-scale scheme, making the existing diagnostics somewhat redundant.
This produces plots of large scale and convective precipitation in the validation note.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - conv_precip/run1
Suite Information
Task Information
✅ succeeded tasks - 1210
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review