Repository navigation
Fix save failures caused by invalid filename characters - #107
Open
LingYi-Liang wants to merge 1 commit into
Open
LingYi-Liang wants to merge 1 commit into
LingYi-Liang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
Text such as
2026/10/03produces path separators in the generated filename, so saving fails even when the output directory exists and is writable.Replace path separators, Windows-invalid characters and ASCII control characters in the text fragment with underscores. Unicode text (including Chinese), the existing first-10-character truncation, and full video task IDs are preserved.
The same replacement rules apply on all platforms, so
:and?are also replaced on systems such as Linux where those characters are allowed.Added 30 filename regression cases that write files in temporary directories. On Windows with Python 3.11.9, all 36 tests pass, including the existing six utility tests; the original code fails 22. No model API calls were made.
Run:
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.