Skip to content

RegionRenderCacheBuilder -> VertexBufferLayers (or WorldRendererLayers) #293

Closed

Description

@Niko-sk2x

This class doesn't have anything to do with RegionRenderCache (which is now removed and ChunkCache is used everywhere).

Based on what this class does, WorldRendererLayers or VertexBufferLayers would be better names for that.

There is some inconsistency in naming, so I'm not sure which name would be better. Method names suggest WorldRendererLayers but their return types suggest VertexBufferLayers.

Activity

  1. modified the milestone: 1.12.0 on Nov 16, 2016
  2. kashike commented on Jun 8, 2017

    @kashike
    Collaborator

    BlockRenderLayers?

  3. Niko-sk2x commented on Jun 8, 2017

    @Niko-sk2x
    Author

    That seems fine too, but I didn't look at the code for a long time.

  4. bs2609 commented on Jun 9, 2017

    @bs2609
    Contributor

    Looking at the class, it's just a collection of VertexBuffers, one for each BlockRenderLayer.
    Perhaps RenderLayerBuffers?

    The field/method names could do with an update too, tbh.

    Initial suggestions:

    • field_179040_a: worldRenderers -> vertexBuffers
    • func_179038_a: getWorldRendererByLayer -> getVertexBuffer
    • func_179039_a: getWorldRendererByLayerId -> getVertexBuffer

    Edit:
    #258 happened, this VertexBuffer is now BufferBuilder.

  5. bs2609 commented on Jun 9, 2017

    @bs2609
    Contributor

    References to the old class name:

    Fields:

    • ChunkRenderWorker.regionRenderCacheBuilder (field_178478_c)
    • ChunkCompileTaskGenerator.regionRenderCacheBuilder (field_178550_e)

    Methods:

    • ChunkRenderWorker.getRegionRenderCacheBuilder (func_178475_b)
    • ChunkCompileTaskGenerator.getRegionRenderCacheBuilder (func_178545_d)
    • ChunkCompileTaskGenerator.setRegionRenderCacheBuilder (func_178541_a)
    • ChunkRenderWorker.freeRenderBuilder (func_178473_b)
    • ChunkRenderDispatcher.freeRenderBuilder (func_178512_a)
    • ChunkRenderDispatcher.allocateRenderBuilder (func_178515_c)
  6. modified the milestones: 1.12.0, 1.13.0 on Sep 18, 2017
  7. modified the milestones: 1.13.0, 1.14.0 on Sep 5, 2018
  8. kashike commented on Aug 26, 2020

    @kashike
    Collaborator

    Issues regarding class and package names are now handled in the MCPConfig repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions