You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This class doesn't have anything to do with RegionRenderCache (which is now removed and ChunkCache is used everywhere).
Based on what this class does, WorldRendererLayers or VertexBufferLayers would be better names for that.
There is some inconsistency in naming, so I'm not sure which name would be better. Method names suggest WorldRendererLayers but their return types suggest VertexBufferLayers.
Activity
kashike commentedon Jun 8, 2017
BlockRenderLayers?Niko-sk2x commentedon Jun 8, 2017
That seems fine too, but I didn't look at the code for a long time.
bs2609 commentedon Jun 9, 2017
Looking at the class, it's just a collection of
VertexBuffers, one for eachBlockRenderLayer.Perhaps
RenderLayerBuffers?The field/method names could do with an update too, tbh.
Initial suggestions:
field_179040_a:worldRenderers->vertexBuffersfunc_179038_a:getWorldRendererByLayer->getVertexBufferfunc_179039_a:getWorldRendererByLayerId->getVertexBufferEdit:
#258 happened, this
VertexBufferis nowBufferBuilder.bs2609 commentedon Jun 9, 2017
References to the old class name:
Fields:
ChunkRenderWorker.regionRenderCacheBuilder(field_178478_c)ChunkCompileTaskGenerator.regionRenderCacheBuilder(field_178550_e)Methods:
ChunkRenderWorker.getRegionRenderCacheBuilder(func_178475_b)ChunkCompileTaskGenerator.getRegionRenderCacheBuilder(func_178545_d)ChunkCompileTaskGenerator.setRegionRenderCacheBuilder(func_178541_a)ChunkRenderWorker.freeRenderBuilder(func_178473_b)ChunkRenderDispatcher.freeRenderBuilder(func_178512_a)ChunkRenderDispatcher.allocateRenderBuilder(func_178515_c)kashike commentedon Aug 26, 2020
Issues regarding class and package names are now handled in the MCPConfig repository.