You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Obfuscated names of constructors for classes where there are multiple matching names are incorrect #373
It seems that the obfuscated name is using the wrong class name. This only affects the display in MCPBot, since constructors aren't remapped (in fact, they're named <init> in the bytecode), so there is no name to remap. However, it's definitely a bug.
Fixing this properly would require a data model change due to the way that the MCP data is represented in the bot database. I can, however, most likely fix this in the bot output. Just have to make sure I find all the places that it can happen.
Fixed and live. Please take a look at obf method names in the bot output, though, to make sure the fix did not screw anything up. Basically I just changed the db view to return the class obf name instead of the method obf name only for constructors.
Activity
bspkrs commentedon Mar 28, 2017
Fixing this properly would require a data model change due to the way that the MCP data is represented in the bot database. I can, however, most likely fix this in the bot output. Just have to make sure I find all the places that it can happen.
bspkrs commentedon Mar 28, 2017
Oh... or I can fix it in the view that everything reads from! That will be much easier to fix.
bspkrs commentedon Mar 28, 2017
Fixed and live. Please take a look at obf method names in the bot output, though, to make sure the fix did not screw anything up. Basically I just changed the db view to return the class obf name instead of the method obf name only for constructors.
Pokechu22 commentedon Mar 28, 2017
Looks good to me. Can you push that commit to profmobius/MCPBot?