You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great suggestion in general, just two (or one?) minor nitpick: You go for onActivation but you kept the onDestroyedByX names. I'd say for conistency's sake that either the first one should be onActivated or the latter ones should be onDestructionByX.
I think the noun makes more sense than the participle and the latter is in fact not even correct grammatically (I think 🤔). The only "problem" I could see is that the 'on' + participle form is used a lot for other methods already, but there doesn't appear to be any consistency (e.g. onItemUse vs onBlockAdded) anyways.
I'd still go for the on prefix rather than omitting it like @kashike suggests, since you underline the 'event-ness' of the methods that way.
I feel like this doesn't require a separate issue, so an additional suggestion: func_149634_a: getBlockFromItem -> fromItem/fromItemBlock
I personally prefer the latter since people don't get illusions about magically getting the block from an item like that (especially for Vanilla things that inherit ItemBlockSpecial).
Activity
marvin-roesch commentedon Sep 19, 2017
Great suggestion in general, just two (or one?) minor nitpick: You go for
onActivationbut you kept theonDestroyedByXnames. I'd say for conistency's sake that either the first one should beonActivatedor the latter ones should beonDestructionByX.bs2609 commentedon Sep 19, 2017
Didn't think of
onDestructionat the time, which do you prefer?kashike commentedon Sep 19, 2017
Another option is something like:
func_180639_a:onBlockActivated->activatedfunc_180652_a:onBlockDestroyedByExplosion->explodedfunc_180649_a:onBlockClicked->clickedmarvin-roesch commentedon Sep 19, 2017
I think the noun makes more sense than the participle and the latter is in fact not even correct grammatically (I think 🤔). The only "problem" I could see is that the 'on' + participle form is used a lot for other methods already, but there doesn't appear to be any consistency (e.g.
onItemUsevsonBlockAdded) anyways.I'd still go for the
onprefix rather than omitting it like @kashike suggests, since you underline the 'event-ness' of the methods that way.covers1624 commentedon Sep 19, 2017
I agree, the "event-ness" of the method names needs to be kept, It makes them sound more like a field without it.
marvin-roesch commentedon Sep 22, 2017
I feel like this doesn't require a separate issue, so an additional suggestion:
func_149634_a:getBlockFromItem->fromItem/fromItemBlockI personally prefer the latter since people don't get illusions about magically getting the block from an item like that (especially for Vanilla things that inherit
ItemBlockSpecial).kashike commentedon Jul 13, 2018
field_149764_J:blockMaterial->materialfunc_180652_a:onBlockDestroyedByExplosion->onExplosionDestroyfunc_176206_d:onBlockDestroyedByPlayer->onPlayerDestroyfunc_180634_a:onEntityCollidedWithBlock->onEntityCollisionfield_149762_H:blockSoundType→soundType[-]Deblocking Block methods[/-][+]Deblocking Block fields/methods[/+]