You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall great suggestions, only the withSubtypes jumps out at me, but I also can't come up with a better name off the top of my head, except maybe enableSubtypes to express the side effects more clearly. There's also a small typo in getEnchantablility ^^
Here's the onEvent names that could do with changing. I've included the names that I thought sounded best individually, but any suggestions for good names that are more consistent would be welcome.
Activity
marvin-roesch commentedon Sep 20, 2017
Overall great suggestions, only the
withSubtypesjumps out at me, but I also can't come up with a better name off the top of my head, except maybeenableSubtypesto express the side effects more clearly. There's also a small typo ingetEnchantablility^^bs2609 commentedon Sep 20, 2017
Here's the
onEventnames that could do with changing. I've included the names that I thought sounded best individually, but any suggestions for good names that are more consistent would be welcome.Item:func_180614_a:onItemUse->onUse?func_77659_a:onItemRightClick->onRightClick?func_77654_b:onItemUseFinish->onFinishedUsing?func_77615_a:onPlayerStoppedUsing->onStoppedUsing?ItemStack:func_179546_a:onItemUse->onUse?func_77957_a:useItemRightClick->onRightClick?func_77950_b:onItemUseFinish->onFinishedUsing?func_77974_b:onPlayerStoppedUsing->onStoppedUsing?williewillus commentedon Sep 20, 2017
onItemUse/onItemRightClick are still ambiguous. Since we're renaming we can take the opportunity to clarify those.
onItemUse is when the item is right clicked while targeting a block, onItemRightClick is when onItemUse passes or the player is not targeting a block
marvin-roesch commentedon Sep 22, 2017
I feel like this doesn't require a separate issue, so an additional suggestion:
func_150898_a:getItemFromBlock->fromBlockkashike commentedon Aug 29, 2018
func_77639_j:getItemStackLimit->getMaxStackSizefunc_111205_h:getItemAttributeModifiers->getAttributeModifiersfunc_77956_u:isItemEnchantable->isEnchantablefunc_77948_v:isItemEnchanted->isEnchantedfunc_77661_b:getItemUseAction->getUseActionfunc_77626_a:getMaxItemUseDuration->getUseDurationfunc_77975_n:getItemUseAction->getUseActionfunc_77988_m:getMaxItemUseDuration->getUseDurationfield_77697_d:itemRand->randomfunc_77951_h:isItemDamaged->isDamagedfunc_77952_i:getItemDamage->getDamagefunc_77964_b:setItemDamage->setDamagefunc_77984_f:isItemStackDamageable->isDamageable