You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure I would rename ITextComponent to IComponent, it becomes too general and at first glance I'd never think IComponent would be for the Text framework.
That said, I was thinking to not do the bottom three changes and instead keep the stuff at the top with one change
Activity
[-][1.13] New names for text components[/-][+]New names for text components[/+]Zidane commentedon Aug 29, 2018
Not sure I would rename ITextComponent to IComponent, it becomes too general and at first glance I'd never think IComponent would be for the Text framework.
That said, I was thinking to not do the bottom three changes and instead keep the stuff at the top with one change
TextComponentBase→AbstractTextComponentJust my thoughts.
Daomephsta commentedon Aug 30, 2018
Why not go halfway? MCP is trying to use vanilla names where they're known, but I agree that
TextComponentis clearer thanComponent. So it would be:TextComponentBase→BaseTextComponentTextComponentString→TextComponentTextComponentTranslation→TranslatableTextComponentTextComponentScore→ScoreTextComponentTextComponentSelector→SelectorTextComponentTextComponentKeybind→KeybindTextComponentTextComponentUtils→TextComponentsTextComponentTranslationFormatException→TranslatableTextComponentFormatExceptionkashike commentedon Aug 26, 2020
Issues regarding class and package names are now handled in the MCPConfig repository.