Skip to content

New names for text components #694

Closed

Description

@0f-0b

As shown in their toString methods:

  • TextComponentBase → BaseComponent
  • TextComponentString → TextComponent
  • TextComponentTranslation → TranslatableComponent
  • TextComponentScore → ScoreComponent
  • TextComponentSelector → SelectorComponent
  • TextComponentKeybind → KeybindComponent

These names should be changed as well, to match the names above:

  • ITextComponent → IComponent
  • TextComponentUtils → Components
  • TextComponentTranslationFormatException → TranslatableComponentFormatException

Activity

  1. changed the title [-][1.13] New names for text components[/-] [+]New names for text components[/+] on Aug 25, 2018
  2. added this to the 1.14.0 milestone on Aug 25, 2018
  3. Zidane commented on Aug 29, 2018

    @Zidane

    Not sure I would rename ITextComponent to IComponent, it becomes too general and at first glance I'd never think IComponent would be for the Text framework.

    That said, I was thinking to not do the bottom three changes and instead keep the stuff at the top with one change

    TextComponentBase → AbstractTextComponent

    Just my thoughts.

  4. Daomephsta commented on Aug 30, 2018

    @Daomephsta

    Why not go halfway? MCP is trying to use vanilla names where they're known, but I agree that TextComponent is clearer than Component . So it would be:

    • TextComponentBase → BaseTextComponent
    • TextComponentString → TextComponent
    • TextComponentTranslation → TranslatableTextComponent
    • TextComponentScore → ScoreTextComponent
    • TextComponentSelector → SelectorTextComponent
    • TextComponentKeybind → KeybindTextComponent
    • TextComponentUtils → TextComponents
    • TextComponentTranslationFormatException → TranslatableTextComponentFormatException
  5. kashike commented on Aug 26, 2020

    @kashike
    Collaborator

    Issues regarding class and package names are now handled in the MCPConfig repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions