Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa2b2938-9ca6-4b67-a11a-f131b554d603
|
FixLab CI failed and was contained without modifying source. Evidence is retained in the workflow artifacts: https://github.com/MonaDevAI/FixLab/actions/runs/38304742298 |
There was a problem hiding this comment.
🟡 Changes recommended
The new approval paragraph references an undefined closure policy and uses ambiguous terminology.
1 open finding
What changed in this PR
Adds public guidance for discovering and safely using repository-owned private adapters.
Changes:
- Documents adapter package, feed, access, and approver discovery.
- Reinforces credential and approval boundaries.
| File | Description |
|---|---|
docs/repository-onboarding.md |
Adds optional private-adapter onboarding guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+124
to
+125
| An adapter must not bypass approval gates. Publication approval, unsafe-data | ||
| approval, and the no-automatic-closure rules for findings still apply. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an 'Optional private adapters' section to docs/repository-onboarding.md. It tells owning teams to document the package, feed, access and approver in their private repo, without naming internal packages in public FixLab. Docs-only; check-docs passes.