[pull] main from nodejs:main - #1868
Merged
Merged
Conversation
* chore: update next-env.d.ts * feat: minimize mobile nav empty space (#8719) Only render the navItems container when the array has items to prevent an empty padded container from creating unwanted space in the mobile navigation. * Update import path for routes type definitions Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com> * Update packages/ui-components/src/Containers/NavBar/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com> * Fix conditional rendering of navItems in NavBar Is this breaking the build with navItems?.length > 0 && Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com> * Remove blank line in NavBar component Removed unnecessary blank line before the main navigation items div. Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com> * style: fix prettier formatting in NavBar --------- Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )