Repository navigation
Fix f_hutch_cam PV prefix - #150
Merged
Nghia T. Vo (nghia-vo) merged 2 commits intoNov 12, 2026
Merged
Conversation
Pins each IOC-served detector and camera prefix, in the profile and in the GUI's camera list, to the IOC's PREFIX in ioc_host_vars. Fails for f_hutch_cam. Assisted-by: copilot:claude-opus-5-5
The hutch-f-cam IOC serves XF:27ID1-ES{GigE-Cam:5} (ioc_host_vars); XF:27IDA-BI{GigE-Cam:5} is not found from xf27id1-ws2, so bluesky could not reach the camera while the CS-Studio screen could.
Assisted-by: copilot:claude-opus-5-5
Anthony Sligar (sligara7)
requested review from
Jakub Wlodek (jwlodek) and
Nghia T. Vo (nghia-vo)
November 12, 2026 22:01
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the F-hutch camera PV prefix correction.
No open issues 🎉
What changed in this PR
Corrects the F-hutch camera’s PV prefix to match its IOC, aligning the Bluesky collection profile and GUI with the working camera endpoint.
Changes:
- Updates
f_hutch_camto useXF:27ID1-ES{GigE-Cam:5}in both locations. - Adds regression tests that check configured detector and camera prefixes against expected IOC values.
| File | Description |
|---|---|
tests/test_device_prefixes.py |
Adds prefix checks for the collection profile and GUI cameras. |
src/hextools/profiles/collection.py |
Corrects the F-hutch camera’s detector prefix. |
src/hextools/gui/__main__.py |
Applies the corrected prefix to the GUI camera viewer. |
Review effort: Balanced
Nghia T. Vo (nghia-vo)
approved these changes
Nov 12, 2026
Nghia T. Vo (nghia-vo)
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f_hutch_camusedXF:27IDA-BI{GigE-Cam:5}. The hutch-f-cam IOC (ioc_host_varsxf/hex/xf27id1-cam1.nsls2.bnl.gov/hutch-f-cam.yml) servesXF:27ID1-ES{GigE-Cam:5}, so the camera worked in CSS but not in bluesky (reported by Zhong).profiles/collection.pyand in the GUI's camera list.tests/test_device_prefixes.py, which pins each IOC-served detector/camera prefix (profile and GUI) to its IOC's PREFIX. It fails on the first commit and passes on the second. The other prefixes already matched.Verification: mock/unit tests (652 passed, pyright clean). At HEX, from xf27id1-ws2 (read-only):
caget 'XF:27ID1-ES{GigE-Cam:5}cam1:Model_RBV'→GT2460; the old prefix is not found. After merge:await f_hutch_cam.connect()at the beamline.