Repository navigation

upload_pdf_files does not check for file type or format #12

Closed

Assignees

Labels

opened

Experimenting with notebooks can create .ipynb_checkpoints folder in RetrievalAugmentedGeneration/notebooks/dataset.

This will cause upload_pdf_files function to fail when increasing NUM_DOCS_TO_UPLOAD. The issue does not occur with default NUM_DOCS_TO_UPLOAD (100), as the number of .pdf files in dataset.zip is greater than 100.

shubhadeepd
self-assigned this
on Dec 13, 2023
shubhadeepd
added
bugSomething isn't working
on Dec 13, 2023
shubhadeepd commented on Dec 18, 2023
shubhadeepd
on Dec 18, 2023
Collaborator
@OlegSudakov Thanks for pointing this bug out.
This should have been fixed with the latest v0.2.0 release.
https://github.com/NVIDIA/GenerativeAIExamples/blob/main/notebooks/05_dataloader.ipynb
Feel free to close this issue after checking.
shubhadeepd
closed this as completed on Jan 18, 2024
chloecrozier
added 2 commits that reference this issue on Oct 13, 2025
Merge pull request NVIDIA#12 from freshyjmp/jonp/add-github-issue-tem…
488ca50
Merge pull request NVIDIA#12 from freshyjmp/jonp/add-github-issue-tem…
7c8d6ea
buildvoc-agent
added a commit that references this issue on Mar 21, 2026
chore(github): improve PR process and rename workspace (NVIDIA#12)
437d8e3

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

shubhadeepd

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests