You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(server): colocate local driver config construction tests #1853
Refactor the server-side local compute driver config construction so Docker and Podman config helpers and their tests live in a consistent module/location.
Context
PR #1785 review noted that docker_config_reads_bind_mount_opt_in_from_driver_table lives in crates/openshell-server/src/cli.rs, while the equivalent Podman test lives in crates/openshell-server/src/lib.rs.
That placement is currently explained by implementation locality: Docker uses the private build_docker_config(...) helper in cli.rs, and Podman uses podman_config_from_file(...) in lib.rs. The asymmetry is not a behavior bug, but it makes the config parsing tests harder to discover and compare.
Definition of Done
Move Docker config construction out of cli.rs into a server config module or another shared location that matches the Podman path.
Move docker_config_reads_bind_mount_opt_in_from_driver_table with the Docker config constructor.
Keep CLI/config behavior unchanged.
Preserve or improve coverage for Docker and Podman driver-table parsing and config merge precedence.
Update references if any docs or comments name the old helper location.
Closing as completed/superseded by #1974. That refactor moved local compute-driver configuration construction and its tests into the owning driver crates, achieving the ownership and test colocation requested here.
Activity
r3v5 commentedon Jun 25, 2026
Hey guys! I have my vouch request accepted #2004. Can I be assigned to work on this issue? Thanks!
r3v5 commentedon Jun 30, 2026
We can close this issue because PR #1974 (normalize compute driver config acquisition) landed on main and already achieves the same goal.
johntmyers commentedon Sep 17, 2026