Repository navigation
fix(sandbox-backend): confirm renewed boundary credentials within an epoch - #3411
Merged
Merged
Conversation
Authenticate renewed Sandbox Protocol bearers on the existing connection before publishing their fingerprint. Capture the exact authorization header for Attach and Confirm, and preserve the connection and previous fingerprint when confirmation fails. Add regression coverage for repeated renewal, failed confirmation retries, and concurrent token-slot changes. Document that same-epoch renewal preserves pending streams while epoch changes still require an authenticated replacement connection. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 17, 2026 13:35
drew
approved these changes
Sep 17, 2026
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirm a refreshed workload-boundary bearer even when its credential epoch is unchanged. A long-lived workload using only existing streams can otherwise lose its boundary at the original credential expiry despite successful gateway renewal. The correction authenticates the replacement while preserving the connection and pending operations.
Related Issue
Related to #3396's boundary/proxy incident and additive to TCP-recovery PR #3403.
Changes
Testing
mise run pre-commitpassesChecklist