Repository navigation
fix(supervisor): keep session retries during startup - #3765
Merged
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-3765.docs.buildwithfern.com/openshell |
drew
marked this pull request as ready for review
September 28, 2026 05:28
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 28, 2026 05:28
elezar
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the supervisor alive while its gateway session retries during startup. The control readiness socket remains unavailable until the gateway accepts the session, so transient gateway delays leave the sandbox provisioning instead of failing startup after 10 seconds.
Related Issue
No issue required: localized fix for an existing startup timeout that conflicts with the session worker's retry behavior. Observed in Release Dev.
Changes
Testing
mise run pre-commitpassesmise run testpassesmise run e2e:vmpassesmise run cireaches an unrelated local Go SDK failure: tests expect no system gateways, but this host has/etc/openshell/gateways/default.Checklist