Repository navigation
feat(providers): add CLI label creation and filtering - #4265
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-4265.docs.buildwithfern.com/openshell |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The provider label workflow fits the linked issues, and the CLI, filtering, docs, and generated bindings were reviewed. One blocking finding remains: the added public protobuf field changes the schema fingerprint without updating its reviewed value, which is failing all three required Rust test jobs.
Action required: @johntmyers, update the reviewed public schema fingerprint and verify the focused inventory test before pushing a new head.
Blocking findings:
GATOR-5ed7c0d8-01: Update the public schema fingerprint for the new selector field; details are inline.
Carried findings: None.
Gator metadata
- Validation: Maintainer-authored provider CLI feature and label documentation covered by #4250 and #4312.
- Docs: Relevant Fern provider and workspace pages, plus the public CLI skill, are updated.
- Checks: Branch Checks fails on x86_64-linux, aarch64-linux, and aarch64-darwin at the same schema inventory assertion. DCO, Helm gate, and Trivy gate pass.
- E2E: No additional test dispatch in this cycle; review feedback must be addressed before pipeline handoff.
- Head SHA:
5ed7c0d81e2f432f005efa035193e7620f65dce3 - Base SHA:
9a6148fc988a5e7a20a43805a52fdfaad766f8ae - Merge base SHA:
0bca9fb8280045224c910610cba005b7fa5a6a83 - Patch ID:
0eb5b5f7761c4e39006eaede310ca7b0fe1e8967 - Gator payload:
11 - Review mode:
initial - Previous reviewed SHA:
none - Review budget exhausted:
no - Maintainer decision required:
no - Next state:
gator:in-review
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
5ed7c0d to
eb012bf
Compare
|
/ok to test eb012bf |
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Thanks @johntmyers, I checked your schema fingerprint fix and preservation of scoped credential test environments after the rebase. The independent follow-up review found no new blocking findings; the earlier schema finding remains resolved, and all three current-head Rust test jobs pass. The provider and workspace label docs and CLI skill cover the user-facing workflow.
The standard E2E suite is now running on the current head with test:e2e, after the label bot requested a rerun. Gator will inspect its results next cycle.
Blocking findings: None.
Carried findings: None; GATOR-5ed7c0d8-01 remains resolved. The updated public fingerprint accounts for the selector field, while durable and overlap fingerprints are unchanged from the rebased main tree.
Gator metadata
- Validation: Maintainer-authored provider CLI label creation and filtering covered by #4250 and #4312.
- Docs: Relevant Fern provider/workspace pages and public CLI skill updated.
- Checks: Branch Checks, Helm Lint, Trivy Changes, and DCO pass on the current head; no maintainer approval is present.
- E2E:
test:e2eapplied; Branch E2E Checks run 38323413779, attempt 2, is in progress on the current head. The mirror is current, and the existing full-SHA/ok to testremains sufficient. - Head SHA:
eb012bfdd6f2656cfe824e3309f5fe8786b6fab6 - Base SHA:
fe316067dc2503062235106b886c206e9d8ca079 - Merge base SHA:
01c249f225ef43346c9606369974819553b334c3 - Patch ID:
a895da2d5cd7f0f67468abce29b50009bf25b553 - Gator payload:
12 - Review mode:
follow_up - Previous reviewed SHA:
5ed7c0d81e2f432f005efa035193e7620f65dce3 - Review budget exhausted:
no - Maintainer decision required:
no - Next state:
gator:watch-pipeline
Monitoring CompleteMonitoring is complete because this PR has merged. The last Gator state was merge-ready, with maintainer approval and successful required CI and E2E gates. I am removing the active Gator metadata
|
Summary
Provider labels were available only through API creation, and provider lists could not filter them. Add CLI label creation, inspection, and filtering, and document the workspace and provider label workflows.
Related Issue
Closes #4250
Closes #4312
Changes
provider create --label KEY=VALUE,provider list --label-selector key=value,key2=value2, and labels inprovider getoutput.ListProvidersRequest.label_selectorand reuse gateway selector filtering before pagination for named and all-workspaces scopes. Bind continuation tokens to the selector and preserve authorization and credential redaction.Testing
Rebased onto current main, preserving the ADC test environment isolation and regenerating Go bindings.
Updated the reviewed public schema fingerprint; durable and overlap fingerprints remain unchanged from main. All 2,078 gateway unit tests and 82 provider CLI integration tests and eight provider auto-creation tests passed after rebase.
Provider CLI parsing tests and both provider CLI integration suites passed.
Gateway label filtering tests, non-member authorization tests, and provider workspace-isolation test passed.
mise run sdk:ts:ciandmise run go:cipassed; Python protobuf generation passed.mise run docs, Markdown lint, andgit diff --checkpassed. Fern reported the existing gateway configuration MDX, unauthenticated redirect-check, and theme-contrast warnings.Full
mise run pre-commitpassed through the commit hook.Unit and integration tests added/updated.
E2E changes are not applicable; this does not change sandbox or deployment infrastructure.
Checklist