Skip to content

chore(deps): accept build-only zip advisories - #4710

Merged
SDAChess merged 1 commit into
mainfrom
chore/zip-build-advisory-exceptions/SDAChess
Oct 19, 2026
Merged

SDAChess merged 1 commit into
mainfrom
chore/zip-build-advisory-exceptions/SDAChess

Conversation

@SDAChess

Copy link
Copy Markdown
Member

Summary

Temporarily accept RUSTSEC-2026-0367, RUSTSEC-2026-0368, and RUSTSEC-2026-0369 for zip 8.6.0. It is used only by the z3-sys build script when prebuilt-z3 enables downloading and extracting upstream Z3 GitHub release assets; it is not linked into OpenShell or used to process runtime/user archives.

The accepted exposure is build-time extraction of a compromised upstream release asset. System and source-built Z3 paths do not use zip. The advisory check includes this optional path because it checks all features.

Related Issue

No issue, as explicitly requested by the maintainer. Repository ADMIN access verified.

Changes

  • Add advisory-specific exceptions with the accepted exposure documented in deny.toml.
  • Remove these exceptions once z3-sys supports patched zip >=9; its current ^8.2 constraint prevents that upgrade.
  • Keep dependency versions, feature coverage, and other advisory checks unchanged.

Testing

  • cargo deny check advisories reproduced all three failures before the change and passes afterward (run through nix develop .#default --no-write-lock-file).
  • git diff --check passes.
  • Unit and E2E tests are not applicable to advisory configuration only.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs: not applicable.

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@alangou

alangou commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

lgtm keeping track of z3 future updates

@SDAChess
SDAChess enabled auto-merge October 19, 2026 12:59
@SDAChess
SDAChess added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit b4cf1dd Oct 19, 2026
81 checks passed
@SDAChess
SDAChess deleted the chore/zip-build-advisory-exceptions/SDAChess branch October 19, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants