Repository navigation
feat(supervisor): advertise accepted application route installations - #4940
TaylorMutch wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4940.docs.buildwithfern.com/openshell |
04a0ed7 to
b89eaa2
Compare
b89eaa2 to
c011626
Compare
40b3c69 to
e1f8b17
Compare
e1f8b17 to
600d3d3
Compare
0ce10f0 to
0686cd7
Compare
0686cd7 to
bbfccda
Compare
bbfccda to
73e1bed
Compare
d3c89a2 to
385d228
Compare
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. rust-sdk — No explicit risk acceptance foundComplete
2. typescript-sdk — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
6787e29 to
7e5aecc
Compare
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
7e5aecc to
af92283
Compare
|
Regarding the compatibility findings above: these changes affect the internal gateway–supervisor session protocol, which The raw Rust and TypeScript bindings expose those messages, so the reported source changes are real: complete The protobuf additions are wire-compatible. The gateway issues application route leases only when the app listener is enabled and the supervisor advertises The PR author has explicitly accepted the source-compatibility impact on this internal contract. Public-facing API compatibility remains the requirement; these findings do not warrant deferring or redesigning the internal protocol additions. |
Summary
Persist validated, expiring evidence of application routes installed by supervisors. Integrate the shared-supervisor ownership authority merged in #4864 so dedicated and shared installations can be advertised safely.
Based on main at
87ab3d4bf.Related Issue
Closes #4939. Part of RFC 0017.
Changes
ComputeDriverAppEndpoints.ResolveSupervisorAppEndpointextension RPC, independently ofGetSandbox. The baselineComputeDriverservice and existing factories remain compatible. In-process factories register the optional resolver during build; unsupported drivers withhold publication; resolution failures cannot fail ordinary sandbox observations.Release Notes
Testing
Live Kubernetes validation preceded integration of the latest listener hardening;
focused Rust regressions validate that final integration. New-head CI is pending.
Qualification limits
Live HA validation exercised supervisor process/Pod loss on a local k3d cluster. Whole-node failure, real network partitions, metric-driven HPA, sustained production load, and published release artifacts remain unqualified. Grant-file projection contributes to revocation propagation time. Main now includes #4842 for gateway-mediated hashed hostnames. Direct application-listener/discovery hostnames remain readable; extending hashed naming to that path and installation-status presentation (#4670) remain separate work.
The example Kubernetes HTTPRoute controller is a deferred compatibility POC outside this stack.
Checklist
PR dependency order: #4940 → #4941 → #4956 → #4963 → #4964 → #4957.