Repository navigation
Configure CDI annotation prefixes in toolkit container when CDI is enabled - #3088
Draft
cdesiniotis wants to merge 1 commit into
Draft
cdesiniotis wants to merge 1 commit into
cdesiniotis wants to merge 1 commit into
Conversation
…abled This aligns the transformToolkitCtrForCDI() method with the transformDevicePluginCtrForCDI() to ensure the same prefixes are configured with both components. Without explicitly configuring the CDI annotation prefixes in the toolkit container, the nvidia-ctk-installer was NOT adding these annotation prefixes to containerd's (or crio's) container_annotations allowlist. As a consequence, any container annotations set by the k8s-device-plugin, in its AllocateResponse, were not making it into the OCI runtime spec for the container. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
tariq1890
approved these changes
Oct 20, 2026
tariq1890
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks @cdesiniotis !
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aligns the transformToolkitCtrForCDI() method with the transformDevicePluginCtrForCDI() to ensure the same prefixes are configured with both components.
Without explicitly configuring the CDI annotation prefixes in the toolkit container, the nvidia-ctk-installer was NOT adding these annotation prefixes to containerd's (or crio's) container_annotations allowlist. As a consequence, any container annotations set by the k8s-device-plugin, in its AllocateResponse, were not making it into the OCI runtime spec for the container.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing