Skip to content

add a tolerations field for Helm - #3090

Open
kube-gopher wants to merge 1 commit into
NVIDIA:mainfrom
kube-gopher:nfd-gc-tolerations
Open

kube-gopher wants to merge 1 commit into
NVIDIA:mainfrom
kube-gopher:nfd-gc-tolerations

Conversation

@kube-gopher

Copy link
Copy Markdown

Description

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Signed-off-by: kube-gopher <jzlyy68@gmail.com>
@kube-gopher
kube-gopher requested a review from a team as a code owner October 18, 2026 10:09
@copy-pr-bot

copy-pr-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kube-gopher kube-gopher changed the title helm: add the tolerations field add a tolerations field for Helm Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/gpu-operator/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Enterprise
  • Run ID: 659eb0ef-f26c-4c6f-ab52-112369cf71c8
📥 Commits

Reviewing files that changed from the base of the PR and between dbb11e8 and 49e93d9.

📒 Files selected for processing: 1
  • deployments/gpu-operator/values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The GPU Operator values add an empty tolerations list under node-feature-discovery.gc.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 49e93

The new empty list preserves the existing GC tolerations behavior, so no actionable merge-blocking risk remains.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant