Repository navigation
Conversation
A NEV packet started a new segment whenever its timestamp was earlier than the previous handled packet's, whatever the type. The file does not order packets of different types: a comment is stamped when the user starts writing it but written when they finish, so it can be later than the spikes written after it, and each such comment split the recording. Compare each packet only with the previous packet of its own type. A real reset sends every type's clock back, so a jump counts only if the packet it is compared with is in the current segment: one reset is one boundary.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlackrockRawIOsplit a spec 2.3/3.0.nevinto a new segment whenever a packet's timestamp was earlier than the previous handled packet's, whatever the packets' types. The file does not order packets of different types: a comment is stamped when the user starts writing it but written to the file when they finish, so it can be a few ms later than the spikes written after it. Each such comment looked like a clock reset, so a recording with comments was split into many segments (in one real 3.0 file: 43 segments against 1 in the.ns3), and spikes outside the first segment were not returned.This compares each packet only with the previous packet of its own type. A real reset sends every type's clock back, so each type jumps at its first packet afterwards; a jump counts only if the packet it is compared with is in the current segment, so one reset is still one boundary. Reset comments ("critical load restart") work as before.
Behavior on the existing test files is unchanged (same "3 undocumented segments" for the PTP-with-gaps file). The new test calls
_get_event_segment_idson synthetic packets and fails on the old code.Idea and the original per-type implementation (for a streaming reader) are from Colin McNabb at Blackrock Neurotech.