Skip to content

Fix official pipeline stage selection - #20

Merged
kartheekp-ms merged 1 commit into
mainfrom
kartheekp-ms-official-pipeline-stage-fix
Oct 16, 2026
Merged

kartheekp-ms merged 1 commit into
mainfrom
kartheekp-ms-official-pipeline-stage-fix

Conversation

@kartheekp-ms

Copy link
Copy Markdown
Contributor

Summary

The official builds following #12 selected RejectUntrustedSource because Build.Repository.Provider is unavailable in template expressions and expanded to Null.

  • Invoke the shared official stage directly, removing the entire custom guard and rejection job as explicitly approved.
  • Preserve the 1ES wrapper, resources, pool, triggers, release parameter default of false, and existing shared-stage parameters.
  • Update pipeline documentation to describe official stable opt-in and the external control boundary accurately.

Intentional behavior change

This removes custom YAML enforcement of repository identity, main-only/non-PR sources, and manual-only stable opt-in. Setting DotnetPackageSkillsReleaseBuild=true still selects the existing stable-version path. Required restrictions must be enforced through Azure DevOps branch/permission controls; no such controls were changed or verified here. Reviewed internal mirror sources and authorized signing resources remain operational prerequisites.

Validation

  • Available PyYAML parser and focused assertions passed for the exact direct-stage include, unchanged surrounding YAML, public nonofficial defaults, release parameter forwarding, and existing stable/prerelease branches.
  • Documentation scope and complete two-file diff reviewed; git diff --check passed.
  • No shared stage, public YAML, eng/common, tool code, signing profiles, or SDK pins changed.

Pending hosted acceptance: Azure DevOps template expansion and a successful signed prerelease run after merge/mirroring. The earlier modified-YAML preview was denied EditBuild; that denial was not retried or bypassed. No official/stable build or real signing was run as part of this change.

Invoke the shared official stage directly and remove the template-time trust guard and rejection job. Update pipeline documentation to match the approved stable opt-in behavior and external control boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22cb86ae-4e2f-4306-a2ea-6231aee0a320
@kartheekp-ms
kartheekp-ms requested a review from a team as a code owner October 16, 2026 21:19
@kartheekp-ms
kartheekp-ms merged commit d37d447 into main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants