Conversation
Contributor
|
Hi @Kev-Roche, |
astirpe
marked this pull request as ready for review
September 17, 2026 06:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mail.message.body and impersonated_author_id are stored computed fields
depending on author_id, so any later write on author_id re-runs them
outside the context in which the message was written. The stamp is then
lost, or the "Logged in as ..." notice is added a second time.
Both values are now set in create(), which also removes the body field
override and a compute that fired on every mail.message in the database.
Steps to reproduce (stamp erased):
"Logged in as " and impersonated_author_id is the admin partner.
for instance by merging the author partner into another contact.
body: the record no longer says who was really behind the keyboard.