Skip to content

[FIX] auth_signup_verify_email: Use reCaptcha - #783

Closed
Cl0ut1eR wants to merge 1 commit into
OCA:17.0from
Cl0ut1eR:17.0
Closed

Cl0ut1eR wants to merge 1 commit into
OCA:17.0from
Cl0ut1eR:17.0

Conversation

@Cl0ut1eR

@Cl0ut1eR Cl0ut1eR commented Apr 3, 2025

Copy link
Copy Markdown

#774
(previous pr with same changes #775 )

Fixes an issue when using the reCaptcha addon together with auth_signup_verify_email.
Currently, passwordless_signup() bypasses the reCaptcha check in the original web_auth_signup() method.

The root cause is that _verify_request_recaptcha_token() is supposed to remove the token from the request, but the same request is then used directly for user creation, resulting in: ValueError: Invalid field 'recaptcha_token_response' on model 'res.users'

@github-actions

github-actions Bot commented Aug 3, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 12, 2025
@pedrobaeza pedrobaeza added this to the 17.0 milestone Aug 12, 2025
@pedrobaeza

Copy link
Copy Markdown
Member

Isn't reCaptcha an extra module?

@Cl0ut1eR

Cl0ut1eR commented Aug 12, 2025

Copy link
Copy Markdown
Author

Isn't reCaptcha an extra module?

Yes but the original implementation of the method _verify_request_recaptcha_token is from base.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 14, 2025
@github-actions github-actions Bot closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants