Repository navigation
docs: fix actor1 nesting in test configuration example - #160
Open
rksharma-owg wants to merge 2 commits into
Open
rksharma-owg wants to merge 2 commits into
rksharma-owg wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's test-data YAML places actor1's headers, query parameters, body parameters, and unauthorized endpoints beside
actor1rather than underneath it. Copying the example makes YAML loadactor1as null, and OFFAT rejects it with “actor1 is required.”Nest those settings under actor1, matching the actor2 example. Add regression tests that load the actual README example, pass it through the configuration validator, and check both actors' values reach populated requests.
Validation: local pytest (10 tests and two actor subtests passed) and wheel/source builds; Ubuntu fork preflight on Python 3.10–3.14 passed the baseline suite, proved the regression fails on the baseline, passed the patched suite, and built distributions. The existing parser's undeclared
requestsimport required an explicit test-environment install; dependency metadata is unchanged.Fork validation: https://github.com/rksharma-owg/OFFAT/actions/runs/38422373559
Tested commit:
13ec8464418caa4fd0ffcb829d8a0c7721fa990eagainstaa4a88640a99411dfce931e7187df921f9926dfb.Fixes #142.