Repository navigation
Fix #1115: optimize table rendering, cache score, purge/minify css/js, and enable virtual threads - #2718
Conversation
…JS, and enable virtual threads
|
Thank you @bhushan4work , hope to look at this somewhere next week :) |
|
@bhushan4work awesome work! Can you fix the failing tests please? then i will do some testing later on this week :) |
|
fixed the 2 failing tests and verified both fixes. the changes are ready for you to test whenever you get time this week. |
The deferred jquery script tag broke the inline challenge-16 snippet, which uses $ while the page is still parsing, and failed Cypress with "$ is not defined". jQuery now loads synchronously again; the other scripts stay deferred. Post the visual-diff PR comment inside a try/catch: when the workflow token has no comment permission (401/403) the result is published to the job summary instead of failing the run, while other errors still fail the step.
🧪 Testing this PR locallyIf you already have the repositoryFirst, make sure the official OWASP WrongSecrets repository is configured git remote get-url wrongsecrets-upstream >/dev/null 2>&1 || \
git remote add wrongsecrets-upstream https://github.com/OWASP/wrongsecrets.gitThen fetch and check out this PR: git fetch wrongsecrets-upstream pull/2718/head:pr-2718
git checkout pr-2718
Or, if you want the contributor branch directlyIf the contributor repository is already configured as git fetch origin
git checkout -b test-pr-2718 origin/fixes#1115🧹 Cleaning up after testingWhen you are finished testing, you can remove the local PR branch: git checkout main
git branch -D pr-2718If you added the git remote remove wrongsecrets-upstream
PR: #2718 |
|
hi @bhushan4work i am a little bit more busy at work and in personal life than expected, i hope to review the last 2 PRs in the upcoming weeks. Simple challenges can be reveiwed quite fast, but other things will take a little longer, apologies! |
|
No worries at all, completely understand! Take your time with the reviews. Thanks for the update |
The shared challenge list must reflect each visitor's own progress after a solve, so cover two sessions through rendered pages. Closes: OWASP#1115
Repeated parsing adds avoidable work to main-screen requests while each visitor still needs session-specific output. Closes: OWASP#1115
Challenges at the same difficulty repeat identical star strings, and each challenge has a fixed environment label. Avoid rebuilding these values during page rendering. Closes: OWASP#1115
The virtual-thread setting applied to only one profile, so normal deployments still used Tomcat platform threads. Closes: OWASP#1115
Requests on the dedicated MCP port otherwise keep using platform threads even when virtual threads are enabled for the application. Closes: OWASP#1115
commjoen
left a comment
There was a problem hiding this comment.
there still seem to be some issue but let me fix that in the master branch. thanks!
What kind of changes does this PR include?
Description
Improves main-screen loading and rendering performance by:
Existing session-dependent behavior and UI functionality are preserved.
Relations
Closes #1115
References
Checklist: