Skip to content

fix(media): make viewer chrome responsive - #198

Merged
veryCrunchy merged 1 commit into
mainfrom
fix/194-media-viewer-spacing
Jul 24, 2026
Merged

veryCrunchy merged 1 commit into
mainfrom
fix/194-media-viewer-spacing

Conversation

@veryCrunchy

Copy link
Copy Markdown
Member

Closes #194

Summary

  • render photos and native video across the full viewer canvas behind overlay controls
  • keep the top action row bounded and status-bar safe in portrait and landscape
  • move RAW/JPEG choices into a separate horizontally scrollable, non-wrapping row
  • retain fit-at-rest zoom, pan, full-quality loading, editing, tags, actions, and navigation behavior
  • add focused layout-policy coverage

Validation

  • :ui:desktopTest --tests dev.obiente.nextcloudnative.app.MediaViewerLayoutTest
  • :ui:compileDebugKotlinAndroid
  • :androidApp:assembleDebug
  • tools/check-repository.sh
  • git diff --check

Copilot AI review requested due to automatic review settings July 24, 2026 21:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the media viewer’s Compose layout policy so photos/native video render across the full viewer canvas (behind overlay chrome) and the top controls remain compact and status-bar safe, including a separate horizontally scrollable RAW/JPEG source row when multiple sources exist.

Changes:

  • Remove fixed vertical media padding and render media full-canvas behind overlay controls.
  • Restructure the viewer header into a bounded primary action row plus an optional separate, horizontally scrollable source-choice row.
  • Introduce a small MediaViewerLayout policy resolver with focused unit coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudMediaViewer.kt Applies the new layout policy: full-canvas media rendering and responsive header/source-choice chrome.
ui/src/commonTest/kotlin/dev/obiente/nextcloudnative/app/MediaViewerLayoutTest.kt Adds deterministic tests for the new layout policy resolver and expected chrome sizing behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@veryCrunchy
veryCrunchy merged commit e47f664 into main Jul 24, 2026
3 checks passed
@veryCrunchy
veryCrunchy deleted the fix/194-media-viewer-spacing branch July 24, 2026 21:58
@veryCrunchy veryCrunchy added priority:P1 Required for the pre-release product experience area:photos Photos, Memories, RAW, people, albums, tags, and editing platform:android Android-specific implementation or validation type:bug labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:photos Photos, Memories, RAW, people, albums, tags, and editing platform:android Android-specific implementation or validation priority:P1 Required for the pre-release product experience type:bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix(media): use the full landscape canvas in the photo viewer

2 participants