Repository navigation
fix(media): make viewer chrome responsive - #198
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the media viewer’s Compose layout policy so photos/native video render across the full viewer canvas (behind overlay chrome) and the top controls remain compact and status-bar safe, including a separate horizontally scrollable RAW/JPEG source row when multiple sources exist.
Changes:
- Remove fixed vertical media padding and render media full-canvas behind overlay controls.
- Restructure the viewer header into a bounded primary action row plus an optional separate, horizontally scrollable source-choice row.
- Introduce a small
MediaViewerLayoutpolicy resolver with focused unit coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudMediaViewer.kt | Applies the new layout policy: full-canvas media rendering and responsive header/source-choice chrome. |
| ui/src/commonTest/kotlin/dev/obiente/nextcloudnative/app/MediaViewerLayoutTest.kt | Adds deterministic tests for the new layout policy resolver and expected chrome sizing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
Summary
Validation
:ui:desktopTest --tests dev.obiente.nextcloudnative.app.MediaViewerLayoutTest:ui:compileDebugKotlinAndroid:androidApp:assembleDebugtools/check-repository.shgit diff --check