Skip to content
This repository was archived by the owner on Oct 31, 2022. It is now read-only.
This repository was archived by the owner on Oct 31, 2022. It is now read-only.

Consider versions from Gradle BOM Files #127

Closed

Description

@jkasten2

Gradle BOM

See Gradle's documentation on what Gradle's bill of materials (BOM) is and what it does.
https://docs.gradle.org/6.5/userguide/platforms.html#sub:bom_import

Requirements

This plugin needs consider any BOM's when picking which versions to enforce.
Today these are ignored which can result in a version being picked which less than the BOM definition.

Example

We should ensure firebase-bom in particular works.
app/build.gradle

dependencies {
    implementation platform('com.google.firebase:firebase-bom:25.3.1')
    // firebase-bom above provides a list of versions,
    //    which is way firebase-messaging does not have a version here
    implementation 'com.google.firebase:firebase-messaging'
}

Related issues

Activity

  1. jkasten2 commented on Jun 15, 2020

    @jkasten2
    ContributorAuthor

    This fix for this was much simpler than first expected as the first guess would have been that a Gradle BOM might have been its own entity. However it was a simple skip of null versions which fell back to applying overrides to BOM's constraints which is part of the normal tree.
    Fix in #128, part of the now release 0.12.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions