Skip to content
This repository was archived by the owner on Oct 31, 2022. It is now read-only.

Update GradleProjectPlugin.groovy - #135

Closed
chancezeus wants to merge 1 commit into
OneSignal:masterfrom
chancezeus:master
Closed

chancezeus wants to merge 1 commit into
OneSignal:masterfrom
chancezeus:master

Conversation

@chancezeus

@chancezeus chancezeus commented Aug 17, 2020 •

Copy link
Copy Markdown
Contributor

Fix maxAndroidSupportVersion returning invalid version string, this fixes issue #110

Fix maxAndroidSupportVersion returning invalid version string
@jkasten2

jkasten2 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

@chancezeus Thanks for the PR! I cherry-picked your commit into #138 where I added a test to cover this and it contains the latest from master to fix the failing test.

@jkasten2

Copy link
Copy Markdown
Contributor

The d3f25ac commit from this PR is now in master. Closing this PR

@jkasten2 jkasten2 closed this Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants