Skip to content

chore: [SDK-5741] run push E2E with Firebase Installation IDs off - #915

Merged
fadi-george merged 1 commit into
mainfrom
fadi/sdk-5741
Nov 11, 2026
Merged

fadi-george merged 1 commit into
mainfrom
fadi/sdk-5741

Conversation

@fadi-george

@fadi-george fadi-george commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Build a second Android demo APK with Firebase Installation IDs off and run the push E2E spec against it.

Details

Motivation

SDK-5741, part of SDK-5734. Since SDK-5686, Android E2E only builds the demo with Firebase Installation IDs (FID) on and a google-services.json. Most customers ship without google-services.json, so E2E no longer covered that path.

Scope

  • The Android build job gets a fid: ['on', 'off'] matrix. The FID flag is true only on the on leg, and google-services.json is written only there (setup-google-services enabled input).
  • The off leg uploads demo-apk-fid-off, and e2e-android passes it as fid-off-app-artifact.
  • The FIREBASE_INSTALLATION_ID_ENABLED define is added to csc.rsp only on the on leg. The legs run one at a time (max-parallel: 1) because each activates a Unity license.
  • sdk-shared appium-e2e.yml (OneSignal/sdk-shared@115a739) runs the full suite on the regular APK and only 02_push on the FID-off APK, with its own test user so the parallel runs don't collide.
  • If either Android build leg fails, both E2E runs are skipped.
  • iOS is unchanged.

Testing

Unit testing

None; CI config only.

Manual testing

actionlint passes on the changed workflow. E2E runs only on rel/** pushes and manual dispatch, so it has not run on this branch yet.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

@fadi-george
fadi-george requested a review from a team as a code owner November 11, 2026 00:19
Base automatically changed from fadi/sdk-5693 to main November 11, 2026 00:37
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george merged commit 26704f4 into main Nov 11, 2026
1 check passed
@fadi-george
fadi-george deleted the fadi/sdk-5741 branch November 11, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants