You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SKPaymentQueue canMakePayments is the source of the leak, so maybe a Radar to Apple?
I did add a settings key kOSSettingsKeyIAPTracking to toggle OneSignal IAP tracking a while ago in a branch on my fork. I tidied it up a little and pushed it: master...jamesstout:opt-out-iap-tracking
As you saw, with IAP tracking on, just an 80 byte leak:
With the IAP tracking off:
However, I'm not suggesting a PR; all tests pass, but I don't know what other impact the change could have.
Activity
jkasten2 commentedon Mar 31, 2016
Thanks for the information, this leak is 80 bytes and will only occur once during app startup so this won't have an impact on your app.
We'll see if there is a way to clean this up so it doesn't pollute the log however going to make this a low priority issue.
jeslyvarghese commentedon Jul 4, 2016
+1
skuske commentedon Mar 1, 2018
Any update on this? Any way to clean that up? Thanks.
skuske commentedon Mar 1, 2018
Actually I am wondering why OneSignal calls
SKPaymentQueue canMakePaymentsduring init...
Can someone shed some light on this, please?
Added settings key “kOSSettingsKeyIAPTracking” to toggle OneSignal IA…
jamesstout commentedon Aug 9, 2018
@skuske It's because OneSignal tracks IAPs: #276
In
initWithLaunchOptions:OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/Source/OneSignal.m
Line 505 in 5fe84b3
Which calls
SKPaymentQueue canMakePayments:OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/Source/OneSignalTrackIAP.m
Lines 48 to 50 in b3044eb
SKPaymentQueue canMakePaymentsis the source of the leak, so maybe a Radar to Apple?I did add a settings key
kOSSettingsKeyIAPTrackingto toggle OneSignal IAP tracking a while ago in a branch on my fork. I tidied it up a little and pushed it: master...jamesstout:opt-out-iap-trackingAs you saw, with IAP tracking on, just an 80 byte leak:
With the IAP tracking off:
However, I'm not suggesting a PR; all tests pass, but I don't know what other impact the change could have.
skuske commentedon Aug 10, 2018
@jamesstout
Cool. Thanks a lot! :o)
rgomezp commentedon May 29, 2019
Closing since no other reports of this being an issue
Squashed and merged dynamic triggers into this branch and now needs t…
Merge 021100 into master (#528)
chore: [SDK-5065] pin OneSignal-KMP-SDK to merged crash-retention policy