fix: Updates to take latest serde_valid in rust-server generator - #24334
Merged
Merged
Conversation
dsteeley
marked this pull request as ready for review
July 17, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes required to take serde_valid. Note these changes are slightly academic as the rust-server has compile time enum verification so this isn't hit.
I don't want to remove this case as there's a risk it's used in a future change. Therefore fixing here.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Update the Rust server generator to work with the latest
serde_valid, fixing enum validation and bumpingswaggerto7.0.1. This keeps generated projects compiling when thevalidatefeature is enabled.Bug Fixes
validate(r#enum(...))invalidate.mustacheto match currentserde_valid.Dependencies
swaggerfrom7.0.0to7.0.1inCargo.mustacheand all sampleCargo.tomlfiles.Written for commit f2653bd. Summary will update on new commits.