Repository navigation
V1.12.6 - Southern Hemisphere fixes - #217
Merged
Merged
Conversation
ClutchplateDude
commented
Jan 10, 2023
Member
- Fixed all known issues related to running in the southern hemisphere.
- Added support for DIR inversion to interrupt stepper library.
- Hemisphere no longer needs to be defined in config, firmware determines it automatically from the given Latitude, switching at the equator.
- Fixed the logic in Sync call to account for both hemispheres.
- Fixed some logic that stopped tracking when setting home position.
- Fixed a bug that caused the firmware to fail to recognize the end of very short slews.
- Added Meade Extension command to query remaining tracking time
- Added Meade Extension command to query the hemisphere that is set.
- Binding interrupt stepper library to 0.0.1
Update changelog
- Added support for DIR inversion to interrupt stepper library. - Firmware now determines hemisphere automatically from the given Latitude, switching at the equator. - Fixed the logic in Sync call to account for both hemispheres.
- Cosmetic code updates
- Added XGST command to get safe time remaining. - Fixed tracking stepper not restarting on hemisphere switch. - Reset RA and TRK positions to zero on hemipshere switch. - Fixed a bug that caused the firmware to fail to recognize the end of very short slews. - Reduced RA limit checking cadence to 3s
- Bumped Interrupt Stepper library required to 0.0.2
Changelog updated, cosmetic tweks to mount code.
Contributor
|
Looks like your PR has code that needs to be changed in order to meet our coding standards!
|
Formatting fixes
andre-stefanov
requested changes
Jan 10, 2023
andre-stefanov
approved these changes
Jan 11, 2023
intercipere
added a commit
that referenced
this pull request
Oct 13, 2026
- Symptom: in the southern hemisphere, tracking stops after any DEC move and can't be re-enabled. The safe time (:XGST#) is about 12 h off. - Cause: checkRALimit() still uses the hemisphere-dependent flip test that #217 removed from currentRA(). In the south, the 12 h correction is applied on the wrong side. - Effect without the fix: tracking stops falsely on one side of home, and the real limit never fires on the other. The RA_TRACKING_LIMIT 12 workaround from Discord disables the check entirely. - Test: OAE bench board (ESP32, no motors), using :St to set the latitude, then :MXd/:MXr and :XGST#. Before the fix, the south showed 18.5 h / −4.5 h with tracking stopped; after it, the south matches the north in all six cases. The north is unchanged.
intercipere
added a commit
that referenced
this pull request
Oct 13, 2026
Declination::FromSeconds converted celestial DEC to the axis value with +90° + dec in the southern hemisphere, while the Meade path (fromCelestialSeconds / celestialToAxisSeconds) uses −90° − dec since #217. Both give the same distance from the pole but with opposite sign, so in the south :XGC and LCD POI targets ended up on the other side of the pole without the matching 12 h RA flip, i.e. mirrored through the pole. Effects in the southern hemisphere: - LCD POI gotos landed at RA + 12 h. - :XGC returned DEC stepper positions with the wrong sign, which OATControl uses for the pre-goto DEC limit warning and the DEC slew progress bar. Meade gotos (ASCOM, OATControl, INDI) were not affected. FromSeconds now delegates to fromCelestialSeconds, so all paths share one conversion. Northern hemisphere results are unchanged (90° − dec in both). Tested on an OAE V1 bench board (ESP32, no motors): :XGC vs. a real :Sr/:Sd/:MS goto for 5 targets including meridian flips. Before, the south had the DEC sign mirrored in all cases; after, all 10 cases (south + north) match.
intercipere
added a commit
that referenced
this pull request
Nov 20, 2026
- Symptom: in the southern hemisphere, tracking stops after any DEC move and can't be re-enabled. The safe time (:XGST#) is about 12 h off. - Cause: checkRALimit() still uses the hemisphere-dependent flip test that #217 removed from currentRA(). In the south, the 12 h correction is applied on the wrong side. - Effect without the fix: tracking stops falsely on one side of home, and the real limit never fires on the other. The RA_TRACKING_LIMIT 12 workaround from Discord disables the check entirely. - Test: OAE bench board (ESP32, no motors), using :St to set the latitude, then :MXd/:MXr and :XGST#. Before the fix, the south showed 18.5 h / −4.5 h with tracking stopped; after it, the south matches the north in all six cases. The north is unchanged.
intercipere
added a commit
that referenced
this pull request
Nov 20, 2026
Declination::FromSeconds converted celestial DEC to the axis value with +90° + dec in the southern hemisphere, while the Meade path (fromCelestialSeconds / celestialToAxisSeconds) uses −90° − dec since #217. Both give the same distance from the pole but with opposite sign, so in the south :XGC and LCD POI targets ended up on the other side of the pole without the matching 12 h RA flip, i.e. mirrored through the pole. Effects in the southern hemisphere: - LCD POI gotos landed at RA + 12 h. - :XGC returned DEC stepper positions with the wrong sign, which OATControl uses for the pre-goto DEC limit warning and the DEC slew progress bar. Meade gotos (ASCOM, OATControl, INDI) were not affected. FromSeconds now delegates to fromCelestialSeconds, so all paths share one conversion. Northern hemisphere results are unchanged (90° − dec in both). Tested on an OAE V1 bench board (ESP32, no motors): :XGC vs. a real :Sr/:Sd/:MS goto for 5 targets including meridian flips. Before, the south had the DEC sign mirrored in all cases; after, all 10 cases (south + north) match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.