Repository navigation
refactor: Refactor mount calculations, enhance documentation, and add tests #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andre-stefanov
wants to merge
4
commits into
develop
Choose a base branch
from
refactor/phase-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fd551e5
refactor: update PLAN.md with expanded hardware support and tooling d…
andre-stefanov 314d3e4
feat: add initial architecture documentation for OpenAstroTracker-Fir…
andre-stefanov 791da52
refactor: Refactor Mount RA/DEC Calculation and Coordinate Formatting
andre-stefanov bac998c
test: add unit tests for coordinate calculations at pole targets and …
andre-stefanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EEPROMStore::STORE_SIZEtwo lines down no longer compiles whenUSE_DUMMY_EEPROMis enabled. Line 20 was de-qualified in this PR, but line 25 still readsEEPROMStore::STORE_SIZE. With the enums now being aliases ofhal::eeprom::*, the class no longer has aSTORE_SIZEmember, so building withUSE_DUMMY_EEPROM true(the supported knob inConfiguration_adv.hpp) fails with'STORE_SIZE' is not a member of 'EEPROMStore'. No CI configuration exercises the dummy path, which is why the matrix stays green. Fix: drop theEEPROMStore::prefix on line 25 as well (matching line 20).