Repository navigation
build(ci): compile OAE and WIFI configurations in the build matrix - #329
Open
ClutchplateDude wants to merge 1 commit into
Open
ClutchplateDude wants to merge 1 commit into
ClutchplateDude wants to merge 1 commit into
Conversation
No CI job built oaeboardv1, and no matrix configuration ever set WIFI_ENABLED, so all OAE-only code paths (OAE geometry, the RA_DEC_OFF_WHEN_PARKED option from #323, the onboard A4988 AZ/ALT drivers) and all of WifiControl.cpp were compile-dead in CI. - Add oaeboardv1 to the board matrix: all four steppers always enabled (RA/DEC TMC2209 UART, AZ/ALT A4988), varying INFO_DISPLAY_TYPE, RA_DEC_OFF_WHEN_PARKED, TEST_VERIFY_MODE and DEBUG_LEVEL (16 solutions). - Add WIFI_ENABLED/WIFI_MODE matrix flags on esp32: WIFI_ENABLED=1 builds each of the three wifi modes once, on a canonical carrier configuration (no displays, UART drivers) so the matrix grows by 3 solutions instead of multiplying. All other boards stay at the WIFI_ENABLED=0 default. - Derive OAE from BOARD_OAE_V1 in Configuration.hpp when the local configuration did not define it, so the oaeboardv1 environment is self-sufficient (user-provided OAE configs are unaffected). Fixes #325 Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
What
Three changes so the previously compile-dead configurations get built by CI:
oaeboardv1joins the board matrix (newBuild (oaeboardv1)job). All four steppers always enabled — RA/DEC on TMC2209 UART (on-board, MS pins not routed), AZ/ALT on the on-board A4988s — varyingINFO_DISPLAY_TYPE(incl. the OAE info display),RA_DEC_OFF_WHEN_PARKED(the fix(mount): Parked status, optional RA/DEC off when parked #323 option),TEST_VERIFY_MODEandDEBUG_LEVEL: 16 solutions.WIFI_ENABLED/WIFI_MODEflags; WIFI-on builds each of the three modes once on a canonical carrier config (no displays, UART drivers, no test-verify) so esp32 grows from 24 to 27 solutions instead of multiplying. Other boards stay at the WIFI-off default. This compilessrc/WifiControl.cppin CI for the first time (gap noted on refactor: Refactor mount calculations, enhance documentation, and add tests #314/fix(wifi): keep FAIL_TO_AP mode reachable and truthful after failover #315).OAEis derived fromBOARD_OAE_V1inConfiguration.hpp(guarded by#ifndef), so theoaeboardv1environment is self-sufficient. Existing user configs that defineOAEthemselves are unaffected.Solution counts: esp32 27 (was 24), oaeboardv1 16 (new), all other boards unchanged.
Verification
RA_DEC_OFF_WHEN_PARKEDonly on OAE, mode consistent with enabled).generate_config_file()andPLATFORMIO_BUILD_FLAGS=-DMATRIX_LOCAL_CONFIG=1(the exact CI invocation), each from its own generated config:RA_DEC_OFF_WHEN_PARKED=1✅WIFI_MODE_ATTEMPT_INFRASTRUCTURE_FAIL_TO_AP✅ (WifiControl.cpp.oconfirmed in the build log)ConfigurationValidation(missing MS pins →-Werror), so the guard rails around the new variants are live.🤖 Generated with Claude Code