Repository navigation
Conversation
Every run shared one socket and shut its server down when it started and when it exited, so a run in another worktree or session could kill a run in progress. The failures looked like product faults: a blank frame, a missing draft, a boot that never finished. Starting a second run during the first reproduces them. The default socket now carries the run's process id, and a run removes its socket when it finishes because tmux leaves the file behind. An explicit TUI_SOCKET still works as before.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each run of the terminal suite now gets its own tmux server, so two runs at once can't kill each other.
Context
scripts/tui-testsonly.Changes
Every run used the socket
coven-tui-testand shut that server down when it started and when it exited. A run in another worktree or session could therefore kill a run in progress. The failures look like product faults: a blank frame, a missing draft, a boot that never finishes.TUI_SOCKETnow carries the run's process id.TUI_SOCKETstill works as before.Validation
git diff --check: clean.cargo fmt --all: N/A, no Rust changes.cargo check --workspace: N/A, no Rust changes.cargo clippy --workspace --all-targets -- -D warnings: N/A, no Rust changes.cargo test --workspace: N/A, no Rust changes.TUI failed to boot.--help shows usage line, is from that binary's scratch filename. Case 01 passes when the same binary is namedcoven-code.python3 -m unittest discover -s scripts/tui-tests -p 'test_*.py'passes.coven-tui-test-*socket files were left after any of these runs.PR Readiness
TUI_SOCKETrow.