Skip to content

fix warehouse test data - #2299

Draft
atravitz wants to merge 8 commits into
mainfrom
fix/warehouse_test_data
Draft

atravitz wants to merge 8 commits into
mainfrom
fix/warehouse_test_data

Conversation

@atravitz

@atravitz atravitz commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution:

  • No
  • Yes: [If yes, please provide details here]

Checklist

  • Read the AI Policy and filled in the AI-generated code disclosure.
  • Adhered to the contribution guidelines
  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Added a news entry, or the changes are not user-facing.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz changed the title fix warehouse test fixtures fix warehouse test data Oct 22, 2026
@atravitz
atravitz force-pushed the fix/warehouse_test_data branch from 6b99d6c to 6d9cbdb Compare October 23, 2026 00:07
@atravitz

atravitz commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

looks like the failures could be avoided with pytorch~2.14, but I should probably find a cleaner way to do this.

this does bring up that espaloma is what is keeping us pinned to pytorch<2.4, and is not yet compatible with python 3.13.

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (050260f) to head (74fd54d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   95.14%   90.47%   -4.67%     
==========================================
  Files         227      227              
  Lines       22517    22520       +3     
==========================================
- Hits        21423    20375    -1048     
- Misses       1094     2145    +1051     
Flag Coverage Δ
fast-tests 90.47% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz force-pushed the fix/warehouse_test_data branch 2 times, most recently from 7a8d88f to 239789d Compare October 23, 2026 17:48
@atravitz
atravitz force-pushed the fix/warehouse_test_data branch from 239789d to 9830f5c Compare October 23, 2026 22:16
@atravitz atravitz self-assigned this Oct 23, 2026
@atravitz atravitz added this to the 1.13.1 milestone Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant