Skip to content

Bump various dependencies - #508

Merged
vharseko merged 8 commits into
OpenIdentityPlatform:masterfrom
prthakre:bump_dependencies
Jun 4, 2025
Merged

vharseko merged 8 commits into
OpenIdentityPlatform:masterfrom
prthakre:bump_dependencies

Conversation

@prthakre

@prthakre prthakre commented Mar 26, 2025 •

Copy link
Copy Markdown
Contributor

mojo-executor: 2.4.1
qdox: 2.2.0
maven-plugin-annotations: 3.15.1
jaxws-ri: 2.3.7
logback: 1.5.18
commons-lang3: 3.17.0
freemarker: 2.3.34
grizzly-framework: 2.4.4
metrics-core: 4.2.30
various maven plug-ins

Retain current formatting.

mojo-executor: 2.4.1
qdox: 2.2.0
maven-plugin-annotations: 3.15.1
jaxws-ri: 2.3.7
logback: 1.5.18
commons-lang3: 3.17.0
freemarker: 2.3.34
grizzly-framework: 2.4.1
metrics-core: 4.2.30
various maven plug-ins
@prthakre

Copy link
Copy Markdown
Contributor Author

Why was maven-source-plugin removed

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-source-plugin</artifactId>
</plugin>

To fix following maven error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.1:jar-no-fork (attach-sources) on project opendj-core: Presumably you have configured maven-source-plugin to execute twice in your build. You have to configure a classifier for at least one of them.

@maximthomas
maximthomas self-requested a review March 26, 2025 09:54
@prthakre

Copy link
Copy Markdown
Contributor Author

[build-maven (17, macos-latest)]
(https://github.com/OpenIdentityPlatform/OpenDJ/actions/runs/14080233351/job/39431714914?pr=508#logs)

[26/Mar/2025:10:49:30 +0000] category=org.opends.messages.external severity=ERROR msgID=1 msg=Could not find a valid Docker environment. Please check configuration. Attempted configurations were:
	UnixSocketClientProviderStrategy: failed with exception InvalidConfigurationException (Could not find unix domain socket). Root cause NoSuchFileException (/var/run/docker.sock)
	DockerDesktopClientProviderStrategy: failed with exception NullPointerException (Cannot invoke "java.nio.file.Path.toString()" because the return value of "org.testcontainers.dockerclient.DockerDesktopClientProviderStrategy.getSocketPath()" is null)As no valid configuration was found, execution cannot continue.

@prthakre

prthakre commented Mar 26, 2025 •

Copy link
Copy Markdown
Contributor Author

Failure with 21 on ubuntu:

Error:  Failures: 
Error:    ReplicationDomainTest.exportAndImport:361->assertExportSucessful:458 expected [83890] but found [0]
[INFO] 
Error:  Tests run: 24940, Failures: 1, Errors: 0, Skipped: 0

guava and grizzly were bumped, should I revert grizzly?

@maximthomas

Copy link
Copy Markdown
Contributor

guava and grizzly were bumped, should I revert grizzly?

Yes, please. We need to ensure that this update doesn't cause any issues. We could update the grizzly library in a future pull request.

@prthakre
prthakre force-pushed the bump_dependencies branch from 56b2d83 to 6992147 Compare March 26, 2025 14:05
@prthakre

Copy link
Copy Markdown
Contributor Author

guava and grizzly were bumped, should I revert grizzly?

Yes, please. We need to ensure that this update doesn't cause any issues. We could update the grizzly library in a future pull request.

Done.

@vharseko

Copy link
Copy Markdown
Member

@maximthomas grizzly affected to OpenIDM
very complex PR

@maximthomas
maximthomas self-requested a review May 30, 2025 09:34
Comment thread opendj-doc-maven-plugin/pom.xml Outdated
Comment thread opendj-maven-plugin/pom.xml Outdated

@maximthomas maximthomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @prthakre
Thank you for the contribution.
There are conflicts in the PR and grizzly-framework still affected.
Please fix the PR.
Thanks!

@prthakre

prthakre commented May 31, 2025 •

Copy link
Copy Markdown
Contributor Author

@maximthomas Looking into this.

EDIT: grizzly-framework was bumped to 2.4.1 since anything newer was causing tests to fail

<groupId>org.glassfish.grizzly</groupId>
    <artifactId>grizzly-framework</artifactId>
    <version>2.4.1</version>

@prthakre

Copy link
Copy Markdown
Contributor Author

@maximthomas my local builds are passing with grizzly-framework:2.4.4, is it alright to use this version?
If I recall correctly, 3.x and above have issues

@maximthomas
maximthomas self-requested a review June 2, 2025 05:56
Comment thread opendj-server-example-plugin/pom.xml Outdated
Comment thread pom.xml Outdated
Comment thread opendj-doc-maven-plugin/pom.xml Outdated
Comment thread opendj-maven-plugin/pom.xml Outdated
Comment thread opendj-maven-plugin/pom.xml Outdated

@maximthomas maximthomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @prthakre,
Thank you for your contribution! Everything seems fine except some minor issues.
Please check them.

@prthakre
prthakre requested a review from maximthomas June 2, 2025 13:26
Comment thread pom.xml
Comment thread pom.xml Outdated
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>15.0</version>
<version>33.4.8-jre</version>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build went through fine and all tests have passed.
Why do we want to go back to such a older version?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step used in release workflow only

@prthakre prthakre Jun 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean mvn release:clean release:prepare?
Is the above step failing with 33.4.x, will revert to 15.0

@vharseko
vharseko merged commit a5a5ab8 into OpenIdentityPlatform:master Jun 4, 2025
@prthakre
prthakre deleted the bump_dependencies branch June 4, 2025 15:45
maximthomas pushed a commit to maximthomas/OpenDJ that referenced this pull request Jul 18, 2025
Co-authored-by: Prashant <Prashant.Thakre@vida.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants