Fix unavailable monitoring attributes over JMX - #558
Merged
Merged
Conversation
When the ReplicationBroker switched to a different RS, the replication monitor MBean could remain registered under the old instance. As a result, JMX clients (e.g. JConsole) displayed "Unavailable" for Directory Server replication monitoring attributes. Fixes: - ReplicationBroker#setConnectedRS(): Deregister the ReplicationMonitor before its instance name[^getMonitorInstanceName] changes, otherwise the deregistration will not be successful. - DirectoryServer#deregisterMonitorProvider(): when an MBean has no monitor providers, remove it from the local registry and unregister it from the MBeanServer to avoid stale MBeans. [^getMonitorInstanceName]: https://github.com/WrenSecurity/wrends/blob/09cf0ade4fd10e5e1e7aa7b220e0b7a616a89cfc/opendj-server-legacy/src/main/java/org/opends/server/replication/service/ReplicationMonitor.java#L59 (cherry picked from commit efc93490e3d16cc2426849deb231cbe3bf4f6440)
maximthomas
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ReplicationBroker switched to a different RS, the replication monitor MBean could remain registered under the old instance. As a result, JMX clients (e.g. JConsole) displayed "Unavailable" for Directory Server replication monitoring attributes.
Fixes:
(cherry picked from commit efc93490e3d16cc2426849deb231cbe3bf4f6440)
Footnotes
https://github.com/WrenSecurity/wrends/blob/09cf0ade4fd10e5e1e7aa7b220e0b7a616a89cfc/opendj-server-legacy/src/main/java/org/opends/server/replication/service/ReplicationMonitor.java#L59 ↩