Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
Author
|
I’m keeping this as draft because I haven’t tested it on a physical iPhone/WHOOP 4.0 build yet. The focused tests and analyzer are passing. Could you please review whether this approach makes sense? If it looks okay, can you advise the best way for me to test it on iPhone, or whether a TestFlight build can be created from this patch? |
namahsea
force-pushed
the
validation/manual-sync-refresh
branch
from
October 13, 2026 08:40
118a2ed to
04eddf6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes manual sync behavior so tapping Sync now refreshes enabled phone steps, queues recalculation after steps are saved, and avoids overlapping manual sync runs.
Changes
Validation
Notes
I have not yet verified this on a physical iPhone/WHOOP 4.0 build because the public TestFlight app does not include this patch.
Could you please review this and let me know if this approach is acceptable? If possible, I’d also appreciate guidance on how I can test this on iPhone or whether a TestFlight build can be made after review.
Summary by Sourcery
Ensure manual sync reliably refreshes phone and band data without overlapping runs or leaving stale derived results.
Bug Fixes:
Enhancements:
Tests: