Skip to content

Recover Cox Newton steps lost to objective roundoff - #48

Merged
Ananyapam7 merged 2 commits into
mainfrom
codex/cox-newton-roundoff
Nov 10, 2026
Merged

Ananyapam7 merged 2 commits into
mainfrom
codex/cox-newton-roundoff

Conversation

@Ananyapam7

Copy link
Copy Markdown
Collaborator

Summary

  • Recover a rejected Cox Newton trial when the existing gradient tolerance is satisfied and a direct risk-set calculation verifies a positive penalized likelihood gain above roundoff.
  • Keep the accepted Cox likelihood with its coefficients when recovery fails.
  • Add a deterministic test that rounds the penalized objective while retaining the exact coefficient derivatives. The pre-fix solver rejects the trial in this test.

Validation

  • 285 survival tests passed.
  • 2,915 tests passed across general-family parity, extensions, and GAMLSS public API tests.
  • All 26 Cox tests passed under each of the Haswell, Nehalem, and Sandy Bridge OpenBLAS settings.
  • Ruff, repository hygiene, and the stable-contract type check passed.

@Ananyapam7
Ananyapam7 merged commit 7f7fafa into main Nov 10, 2026
10 checks passed
@Ananyapam7
Ananyapam7 deleted the codex/cox-newton-roundoff branch November 10, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant