Skip to content

Allow username change #233

Closed
Closed

Description

@sizzlemctwizzle

Allow users to choose another unclaimed name.

Also, we should probably prevent users from registering with an email address as their username. A simple regex can catch this and we could display a message saying the their username will be display publicly.

Activity

  1. Martii commented on Jul 1, 2014

    @Martii
    Member

    Perhaps one time only? I'd rather not see a bazillion changes... great for spammers.

    registering with an email address as their username

    +1 ... was thinking about putting a mesage in on the login page but this idea sounds much better... should filter out anything that resembles a web url too.

  2. sizzlemctwizzle commented on Jul 1, 2014

    @sizzlemctwizzle
    MemberAuthor

    Yeah we'll give them one chance to change it.

  3. Zren commented on Jul 1, 2014

    @Zren
    Contributor

    We can't serialize the username anywhere then. We would need to only store the script.owner = user._id and use scriptQuery.populate('owner', 'name').

  4. sizzlemctwizzle commented on Jul 1, 2014

    @sizzlemctwizzle
    MemberAuthor

    We can't serialize the username anywhere then.

    What do you mean? We'll obviously have to change the username in DB everywhere it appears.

  5. Martii commented on Jul 1, 2014

    @Martii
    Member

    change the username in DB everywhere it appears.

    I'm seeing a potential DB label here from this statement with some minimal implied CODE labeling... I think @Zren might be wondering if this should be handled purely in ECMAScript and have the DB store/access a token that represents the username. Either way works but depends on how much DB work, @sizzlemctwizzle, you want to have with this... with a one time only change a DB oriented "fix" might be the better option but we'll need a flag on their account info saying it's already been changed I think.

  6. sizzlemctwizzle commented on Jul 3, 2014

    @sizzlemctwizzle
    MemberAuthor

    with a one time only change a DB oriented "fix" might be the better option

    Yes this is the way to go imo. If you're dealing with core data (username is about as "core" as it gets) you should be doing it in the DB.

  7. joeytwiddle commented on Jul 3, 2014

    @joeytwiddle
    Contributor

    One change only seems a bit limited. How about one change per year? 😃

    Er ... good luck with the DB fix!

    (FWIW in general I think DB records should use the user ID, not the username, to refer to users, although admittedly this does mean the overhead of an extra lookup to resolve the username from the ID every time you need it.)

  8. Martii commented on Jul 3, 2014

    @Martii
    Member

    One change only seems a bit limited. How about one change per year?

    LOL... Once is plenty... if someone can't make up their mind on who they are... well there's a place for that. ;)

    So -1 not to mention it will clutter up the DB with changes and tracking. Pick an identity nickname and stick with it, with one optional approved change for those who accidentally used something they shouldn't have.


    btw @joeytwiddle see https://openuserjs.org/scripts/joeytwiddle/Github_Notifications_Dropdown/issues/SUGGESTIONS

  9. Lorentz83 commented on Jul 9, 2014

    @Lorentz83

    +1
    I registered myself using my github account, but OpenUserJS instead of display my github name shows my email.
    I'd like to keep it more private to prevent spam.

  10. Martii commented on Jul 9, 2014

    @Martii
    Member

    I registered myself using my github account, but OpenUserJS instead of display my github name shows my email.

    I understand your dilema on what you did. Instead of typing in a unique Username you typed in your email address as your username. We'll do what we can to notify new users but if they make the mistake of using an email addy that's technically not the fault of OUJS.

  11. Lorentz83 commented on Jul 9, 2014

    @Lorentz83

    if they make the mistake of using an email addy that's technically not the fault of OUJS.

    Is there a way to delete the account so I can create a new one with the GitHub username? I cannot find it.

  12. 5 remaining items

  13. Martii commented on Mar 10, 2015

    @Martii
    Member

    @JJanz

    This won't be made easy for you as it's not easy for me... ;) :) (slightly outlined at what I have to do too)

    it's using my email.

    Strange that you would refer to yourself as an "it" since you appear to have skipped reading the huge caution box I put in. ;).

    So let me get this squared away here...

    • You just created your userscripts repo about an hour ago.
    • You created your OUJS account without reading the caution box
    • You want to disguise yourself by having an auth removed.
    • Finally you do know that committing anything to GH requires authentication that anyone can view which is how I've found you in our DB... so this one time change in our DB is going to give you a false sense of security. (this is called accountability btw)

    So what I can do... since I'm in a good mood... I can do the one time rename of your account to match here, however the auths you have chosen, especially your initial signup auth method, will be staying. You have to think before you do with OUJS instead of being a drone with other less evolved sites and processes.

    /end giving you a hard time for not reading. ;) :)

    P.S. Your username on OUJS is "JJanz" (without the quotes of course)

  14. Martii commented on Mar 10, 2015

    @Martii
    Member

    but can't remove (or change) them, just add.

    Btw something else for you to read... https://openuserjs.org/user/preferences ... while you are logged in... in case you want to flip to GH as your primary. I would recommend this, especially around April 20th, 2015, since it's still a bit unclear on what is actually deprecated in googles oauth2.

  15. JJanz commented on Mar 10, 2015

    @JJanz

    First, thanks a lot for being this fast. I really appreciate it.

    Also, thanks so much for helping me out. It turned out to be exactly what I intented.

    Then, I have to say: I DO NOT want to disguise myself by having an auth removed. It's not about disguising or security measures and there was no evidence to support your assumption (please don't be a detective ;) ). I thought the context made it perfectly clear but, since it might have not, I'll clarify: I was intending to get a less-spammy username through that. Once I have it, yes, I have no intention to remove it and it sure can stay. And, actually, one of those failed attempts for this more private username was flipping back/forth to/from GH as my primary.

    And, as for the false sense of security, yes, I do know about it. I also do know my email addresses are exposed around the web by a few poorly constructed systems but it doesn't stop me from trying to avoid it as much as doable.

    Last, the huge caution box you put in, which I DID read, is on top of 2 form fields visually glued together, which makes them appear connected. Being so, the Username field seems to mean my username in that service I'm choosing to register my account. There's no clue it's for me to choose a brand new username unrelated to the service. It's (unless I'm wrong) exactly what Lorentz83 went through, which is what I meant by "I went a similar way". And, also, NO OTHER service for which I used Google authentication got my email as username (GreasyFork was only mentioned as an example and suggestion, as they've got my name for that). So, considered all this as context, the huge caution box you put in, which I DID read, sounds like a warning for perhaps another of those authentication methods that might only give email for the system to rely on (and maybe use as username). And that, BTW, is what I meant by "it": the system that seemed to have used my email as username (which, after all figured out, I realize I did mistakenly as it's actually from that field visually connected to the authentication service).

    Hoping it's all cleared out, thanks again.

  16. added
    laterA long time ahead, in a galaxy near, near...
    on Mar 10, 2015
  17. Martii commented on Mar 10, 2015

    @Martii
    Member

    the huge caution box you put in, which I DID read, is on top of 2 form fields visually glued together, which makes them appear connected.

    So your connection wasn't made. ;) You should also realize that I've figured out when creation date has occurred which is why I knew it was a User mistake not a OUJS mistake. Making the leap of saying "some authentication methods may require email addies" isn't anywhere near the current message. Anyhow... thanks for the explanation of your intentions... if I feel a genuine request is asked I'll do my best to accommodate... in which you did but please realize this is nothing like Lorentz83 as that was prior to the notification. Anywho... you are welcome. :) Being a detective is part of the job description and isn't up for debate.

    Bringing this to issue topic... there are several other factors, and other issues to be created and completed, that have to happen before this can even be considered so tagging as a later task. I still think the one time changing is better for accountability to prevent gaming of the system.

  18. JJanz commented on Mar 10, 2015

    @JJanz

    So your connection wasn't made. ;)

    No it wasn't. ;)

    I've figured out when creation date has occurred which is why I knew it was a User mistake

    Actually, no. I did created my GH userscripts repository after my OUJS account but my GH account is from 2012. I had no intention to connect the 2 until I noticed I could have a central place for scripts. However, my problem wasn't even GH related but a mistake I did make led by the semantics of 2 visually related form fields. So I'd like to suggest you guys to visually part them to help newcomers.

    the one time changing is better

    Agreed. It would have helped me in the first place, undoing what I have confused and avoided you some not-quite-you-duty work.

    you are welcome. :)

    Thank you. =)

  19. Martii commented on Mar 10, 2015

    @Martii
    Member

    my problem wasn't even GH related

    Wasn't suggesting that it was a GH issue.

    So I'd like to suggest you guys to visually part them to help newcomers.

    As the notification states...

    "The unique Username that you choose to sign up with here will be displayed to everyone."

    ... is the first sentence... which you didn't connect with. I spent about a month deciding on the correct structure for the message so if you have a concise equal it will be considered... however it is painfully obvious that you missed reading it... perhaps lost in translation? So you may suggest but please include the suggestion rather than allude to it with "it could be parted"... that doesn't help anyone out. It is "glued", as you stated, for the exact reason... you typed in your email, you were cautioned in advance, you did it anyways... our system sanitized it to be non-email and compatible with the DB. :)


    Additional requested username change:

  20. JJanz commented on Mar 11, 2015

    @JJanz

    perhaps lost in translation?

    Maybe. The text itself is fine and gave me the right message but what really troubled me into a second interpretation (which I took) was the context of the rest of the form, as I explained before. Which led me to my suggestion and hopefully ending the OT for this particular issue (sorry about that, you all).

    our system sanitized it to be non-email and compatible with the DB. :)

    That was a good catch. =)

    please include the suggestion rather than allude to it with "it could be parted"... that doesn't help anyone out.

    Sure. And, as I'm on it, I also suggest changing both "Username" placeholders in Login and Register fields to "OpenUserJS Username". It'd make clearer it's unrelated to the authentication service.

    For the Register part, the select input for authentication service could be in a row below "the huge caution box you put in, which I DID read" (sorry, couldn't avoid getting that for its name =D ). And the select could also use a placeholder, maybe an option (disabled, selected by default and first) labeled "OAuth/OpenID service". Then the button could be in a row of its own, being a just 2 lines and a button for a registration form. But lines should not touch each other, keeping only "the huge caution box you put in, which I DID read" touching the input field it's related to, "OpenUserJS Username", making them semantically one field. So a good 5px+ or 10px as margin to the select and to the button would probably do for the visual separation.

  21. xlwmin commented on Sep 30, 2017

    @xlwmin

    @Martii
    Sorry, I made a mistake. I am Chinese, English is not good. When I registered,I didn't pay attention to the notice.So.., Can you help me modify my username to "xlwmin"?
    Thanks in advance.

  22. Martii commented on Oct 2, 2017

    @Martii
    Member

    @xlwmin

    Can you help me modify my username to...

    Complete. Omit the sanitized email portion when logging in e.g. what you wanted it changed to. Also both scripts had to be deleted including statistics as it's much easier and an intended consequence of migrating your account. However I reuploaded them in the order they were originally uploaded.

    Enjoy.

  23. xlwmin commented on Oct 2, 2017

    @xlwmin

    @Martii
    Thanks !

  24. sizzlemctwizzle commented on Oct 17, 2017

    @sizzlemctwizzle
    MemberAuthor

    I'm closing this since improvements have been made which so prevent this from being an issue. If you're registering, you'll have to type your desired username in first. Only then will be displayed sanitized in the registration form where you pick your authentication method. Kind of hard not to get the message that we want you to pick a username for your account on OUJS, not enter some type of login credential for your authentication provider.

  25. removed
    laterA long time ahead, in a galaxy near, near...
    on Apr 18, 2018
  26. locked as resolved and limited conversation to collaborators on Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DBPertains inclusively to the Database operations.enhancementSomething we do have implemented already but needs improvement upon to the best of knowledge.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions