More modals needed for confirmation

[Martii]

Currently when sending something to the graveyard we aren't giving an option to cancel/close. Also setting the "Reason" why... it would be helpful to have a modal popup, similar to Delete Script, to enter in the reason.

We do currently have allocated in the DB a space for this but we aren't utilizing it.

Flagging could also have a reason stored but I don't currently see that capability already.

---

Progress

• Basic modals on User and Script removal
• Reason in modals (See also More modals needed for confirmation #261 (comment))
• Default reasons datalist (See More modals needed for confirmation #261 (comment) and useful to narrow results for Removed items aren't fully searchable #490)

[sizzlemctwizzle]

The flag reason should be optional, where as reason for removal should be
required, but obviously cascading removal (e.g. you remove a user and all
that user's scripts get removed as well) should automatically set an
appropriate reason.

[Martii]

Here's the beginnings... I'm not ready to take this on just yet as an Assignee because I really don't have a clue how to get this part working with the existing remove.js controller.

What am I clearly missing (that's probably staring right in my face) ?? :)

[Martii]

should automatically set an appropriate reason.

I am not quite sure any computer code is that self-aware... usually it's obfuscated code... sometimes it might be undocumented auto liking... e.g. "let's like my fave FB groups in the background without telling you"... I still believe in giving one chance, currently, to not make the same mistake with publishing a script... although there are times that I'd rather not spend a great deal of time being more than fair... but until some more support structure is added to our admin/moderator tasks I think it's best to be a little less stringent until we have most of it all in place.

I took your suggestions and I'm still getting a 404... as this is the 2nd time (yes that's two) that I've twiddled with POST requests... once was on a site that didn't use application/x-www-form-urlencoded... I'm still a bit green outside of xhr's and could use some brief training/pointing out what I've done incorrectly.

[Martii]

Lovely... my test account on dev is removed now... Would someone who knows how to do that restore my alter ego on dev (Martii) please so I can continue with my any testing on this? This is a very good reason to have this modal'ed so things like this don't happen. ;) ... or instruct me explicitly on how to do it?

---

And part of the "Remove User" is in modelParser.js.... this isn't consistent... I'm done twiddling with this part of the issue... if anyone wishes to finish it up I'd be very grateful and probably cletusc too. It's on my branch on my fork... just create your own branch, add a remote of me, fetch from me, then merge into your branch...or use your own code. I'll observe on everything I did and/or didn't do correctly... just be nice and don't abstract it too much in one huge commit please esp. one that runs over the whole issues spectrum... otherwise I'm not going to be much use to OUJS in the medium term. Thanks.

[Martii]

That's pretty much all that I can think of... I don't know how to import the current type with a POST route, and Remove User isn't captured properly, and of course the code for actual removal of a Remove Script and Remove Library is also incomplete.

Any takers/helpers? I can't test without removing an account on dev and being able to restore it after failure in testing.

[sizzlemctwizzle]

I'll be taking over the problems you've been having with #262. We'll leave this issue for when I get around to adding a "Reason" for removal and flagging.