Issue 435 issues category by jerone · Pull Request #445 · OpenUserJS/OpenUserJS.org

jerone · 2014-11-23T23:16:16Z

Ref: #435
After: #443
Fixes: #199

Added new category "Issues" in forum;
- Listing contains only discussions with category issues.
- Sub-forum is accessible from http://localhost:8080/issues and http://localhost:8080/forum/issues per existing route logic.
- Description is "Discussions on scripts" (I'm open to a different/better description when really needed).
- One can not post a new discussion/issue from within the sub-forum (button is disabled).
- Category column is back in this sub-forum, for linking to script's issues page.
Added new category "All Discussions" in forum;
- Listing contains all discussions (including category issues).
- Sub-forum is accessible from http://localhost:8080/all and http://localhost:8080/forum/all per existing route logic.
- Description is "Overview of all discussions" (I'm open to a different/better description when really needed).
- One can not post a new discussion/issue from within the sub-forum (button is disabled).
- Category column is back in this sub-forum, for linking to script's issues page.
Removed all discussions with category issue from main forum.
Moved unknown (e.g. all and issue) category logic to modelParser.
Fixed trailing , on last item in object list.

Updated

Martii · 2014-11-23T23:33:52Z

Removed all discussions with category issue from main forum;

Haven't had a moment to test this... but this seems like you have removed the ability for any Administration to allow patrolling for spammers/etc. Is that what it means?

jerone · 2014-11-23T23:36:33Z

@Martii commented on 24 nov. 2014 00:33 CET:

Removed all discussions with category issue from main forum;

Haven't had a moment to test this... but this seems like you have removed the ability for any Administration to allow patrolling for spammers/etc. Is that what it means?

It means that the main forum page (https://openuserjs.org/forum) listing doesn't contain (excluded) any userscript issues anymore. They are all moved to their sub-forum (http://localhost:8080/issues).

EDIT: please don't edit my posts!!! Even the blockquotes!

Martii · 2014-11-23T23:38:52Z

Well based off of that I think it would be best to expand away with your imagination please because I really need that back for admin'ing and so do some lurkers/visitors.

jerone · 2014-11-23T23:41:02Z

@Martii commented on 24 nov. 2014 00:38 CET:

Well based off of that I think it would be best to expand away with your imagination please because I really need that back for admin'ing and so do some lurkers/visitors.

The you go to http://localhost:8080/issues and you have all scripts issues in one place... even better for admin'ing.

Edit:
Besides, I mentioned it here with your reply supporting it here, makes me think it was oke to include into this PR.

Martii · 2014-11-23T23:50:27Z

I mean all forums and script discussions... that's how I patrol and how moderators and above should be patrolling. Some useful info is gleaned by reading what's happening on script discussions too... also some users appreciate the feedback... You'll be making all of us click up to 5 times instead of just one bookmark/link. I'll support a default option of whatever you choose but if you take out patrolling all discussions completely without adding something to replace it... I don't think it will fly.

Martii · 2014-11-24T00:03:34Z

So yes just simple tested it now that I have bandwidth... how about making an "All discussions" at the top to do this?... consider splitting the UI groups up too (e.g. a spacer)? You'll be making a lot of users/authors and my day if we can get this in. :) e.g. nice work so far.

Zren · 2014-11-24T00:13:01Z

This block of code that fills out category,name should probably be moved to modelParser.parseCategory() since it's getting reused.

Yeah, was thinking about that, I just copied it from categoryListPage. Will do when I get home.

Zren · 2014-11-24T00:16:40Z

This PR will implement #199 when it's merged.

+1 to adding a /forum/all category that has the current behaviour for Martii to monitor.
+1 to merging the current code as well.

Martii · 2014-11-24T00:26:03Z

This PR will implement #199 when it's merged.

Aha that's it... thanks for the find.

jerone · 2014-11-24T07:29:27Z

@Martii commented on 24 nov. 2014 01:03 CET:

... how about making an "All discussions" at the top to do this?...

I can do another category with 'All discussions' ~~and making that default on the main forum page~~. Will do when I get home.

Removing PR READY for above two enhancements.

sizzlemctwizzle · 2014-11-24T10:00:00Z

Just to add my opinion. I like the idea of separating issue and forum discussions, and having an all discussions page. The non-issue discussions should show up by default on the main forum page with links to the other two.

jerone · 2014-11-24T13:59:03Z

@Zren commented on 24 nov. 2014 01:16 CET:

This PR will implement #199 when it's merged.

Thnx, added to first post.

jerone · 2014-11-24T20:53:50Z

Added another category 'All discussions'.

Moved unknown (e.g. all and issue) category logic to modelParser.

First post updated.

Ready for review.

Zren · 2014-11-24T22:24:30Z

Looks good. You even read my mind and made a Category.virtual property to abstract it. ++1

Martii · 2014-11-25T01:19:52Z

+1 mergin'

Issue 435 issues category merge

Martii · 2014-11-25T01:35:55Z

Ughh should have retested this from earlier today...something seems awry... did I miss something? http://localhost:8080/forum shows all... isn't that not what everyone else wanted by:

The non-issue discussions should show up by default on the main forum page

and

I can do another category with 'All discussions' ~~and making that default on the main forum page~~.

??

I can live with it this way (because I'm sort of liking this better)... but say again for confirmation please?

Martii · 2014-11-25T01:40:11Z

n/m this new git build is messing up... reverted and it's fine now.

* Indicate which ones are defaults and which one is "technically" clear * Bug fix... so far we don't have a "rating" on Discussions... removed invalid default query value and put in place `created` since we turned off `updated` if not changed. Post OpenUserJS#1668 Post OpenUserJS#703 OpenUserJS#445 OpenUserJS#435

* Indicate which ones are defaults and which one is "technically" clear * Bug fix... so far we don't have a "rating" on Discussions... removed invalid default query value and put in place `created` since we turned off `updated` if not changed. Post #1668 Post #703 #445 #435 Auto-merge

jerone added 2 commits November 24, 2014 00:07

Added new category 'Issues' in forum;

d9ecd0d

Removed all discussions with category issue from main forum;

d387270

jerone added the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 23, 2014

jerone mentioned this pull request Nov 23, 2014

Better Forum Layout #435

Closed

Zren reviewed Nov 24, 2014
View reviewed changes

jerone removed the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 24, 2014

jerone added 2 commits November 24, 2014 20:47

Added new category 'All Discussions' in forum;

81a25be

Moved unknown/issue category to modelParser;

00f6062

jerone added the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 24, 2014

Martii added a commit that referenced this pull request Nov 25, 2014

Merge pull request #445 from jerone/issue-435-issuesCategory

943c2f7

Issue 435 issues category merge

Martii merged commit 943c2f7 into OpenUserJS:master Nov 25, 2014

jerone deleted the issue-435-issuesCategory branch November 25, 2014 07:00

Martii mentioned this pull request Sep 6, 2020

UI symmetry for Category filters #1751

Merged

github-actions Bot locked as resolved and limited conversation to collaborators May 22, 2021

Conversation

jerone commented Nov 23, 2014

Uh oh!

Martii commented Nov 23, 2014

Uh oh!

jerone commented Nov 23, 2014

Uh oh!

Martii commented Nov 23, 2014

Uh oh!

jerone commented Nov 23, 2014

Uh oh!

Martii commented Nov 23, 2014

Uh oh!

Martii commented Nov 24, 2014

Uh oh!

Zren Nov 24, 2014

Choose a reason for hiding this comment

Uh oh!

jerone Nov 24, 2014

Choose a reason for hiding this comment

Uh oh!

Zren commented Nov 24, 2014

Uh oh!

Martii commented Nov 24, 2014

Uh oh!

jerone commented Nov 24, 2014

Uh oh!

sizzlemctwizzle commented Nov 24, 2014

Uh oh!

jerone commented Nov 24, 2014

Uh oh!

jerone commented Nov 24, 2014

Uh oh!

Zren commented Nov 24, 2014

Uh oh!

Martii commented Nov 25, 2014

Uh oh!

Martii commented Nov 25, 2014

Uh oh!

Martii commented Nov 25, 2014

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants