Fix loadChunksAsync ignoring ChunkStatus passed in - #14220
Merged
lynxplay merged 1 commit intoAug 29, 2026
Merged
Conversation
lynxplay
requested changes
Aug 29, 2026
lynxplay
left a comment
Contributor
There was a problem hiding this comment.
This is the wrong patch to fix this in.
The chunk status param is introduced by moonrise, this diff needs to live in that patch as well.
Contributor
|
Beyond that, LGTM, moonrise correctly uses the param. |
HaHaWTH
force-pushed
the
fix/load-chunk-ignoring-chunkstatus
branch
from
August 29, 2026 11:18
22c6d74 to
4cb0a9e
Compare
Contributor
Author
I've moved the diff into the Moonrise optimization patch |
lynxplay
approved these changes
Aug 29, 2026
granny
added a commit
to PurpurMC/Purpur
that referenced
this pull request
Aug 30, 2026
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@1797fbcc Add PredicateChoice (PaperMC/Paper#12017) [closes #1460] PaperMC/Paper@a2a42c5b Correctly consume chunkStatus in loadChunksAsync (PaperMC/Paper#14220)
granny
added a commit
to PurpurMC/Purpur
that referenced
this pull request
Sep 12, 2026
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@a2a42c5b Correctly consume chunkStatus in loadChunksAsync PaperMC/Paper#14220 PaperMC/Paper@a18bb5b1 Fix a few compiler issues for paper Registry PaperMC/Paper@cd810854 Fix StructureManager lost logic for null levelAccessor PaperMC/Paper@83b7a830 Fix compile issue for TransmuteRecipe PaperMC/Paper@1deca2a0 Update to 26.3-pre-2 PaperMC/Paper@76635f0e Fix missing override from StructurePlacement PaperMC/Paper@851208a3 Fix LootContext#getOptionalParameter to LootContext#getOptional PaperMC/Paper@2215bab4 Fix compile issue for particle in CraftWorld PaperMC/Paper@1aa96bc7 Fix rename for "paper:optionally_flat_bedrock" PaperMC/Paper@079985e7 Fix CustomChunkGenerator but.... PaperMC/Paper@407e0c85 Migrate getNoiseBiome in CustomWorldChunkManager to use BiomeResolver PaperMC/Paper@b7216e5e Draft for Cushion class PaperMC/Paper@2bd7f65b Update data generator to new internals PaperMC/Paper@cc1ddd52 Run generator PaperMC/Paper@e6b568e5 BiomeParameterPoint no longer knows min/max PaperMC/Paper@a66521f4 Bad compile fix for CraftItemType for compostable PaperMC/Paper@bbba7f59 Add Poplar entities (boats) PaperMC/Paper@beec16e9 run rewrite generator PaperMC/Paper@fa56bd9f missing implementation for PoplarBoat and PoplarChestBoat classes PaperMC/Paper@6f211e71 Changes for Cushion API PaperMC/Paper@ca4f1e79 Register missing EntityTypes in CraftEntityTypes PaperMC/Paper@af24f42c Missing paper.at update PaperMC/Paper@2527b3e9 Cushion is not hanging... we need events for that PaperMC/Paper@fcd127f0 Fix compile issues for Pot decorations PaperMC/Paper@ac448e2e Merge branch 'main' of github.com:PaperMC/Paper into dev/26.3 PaperMC/Paper@b207449d Update oldPaperCommit to a2a42c5b12249aaba42a347327fd930a1f94af06 PaperMC/Paper@159fa379 Missing Nullability Annotations for BrewingRecipe PaperMC/Paper@91a004a5 Fix compile issue for Test RegistryHelper PaperMC/Paper@eb676fc9 Update LootTables API PaperMC/Paper@3d615e73 Remove PredicateChoiceMatchingTest (depends on feature patch) PaperMC/Paper@bf771496 Rewrite ItemType PaperMC/Paper@eec5cf30 Missing config for SpigotWorldConfig PaperMC/Paper@0356463b Update EntityEffect PaperMC/Paper@09440a7b Update Effect PaperMC/Paper@ca7ea6f5 Update Particle PaperMC/Paper@aa34f563 Fix POPLAR signs PaperMC/Paper@4f1660d1 Include all the new maps in MapMeta PaperMC/Paper@6dbceabe Fix ItemType#POPLAR_SHELF bad ItemMeta PaperMC/Paper@7a07e7ec Update CommandPermissions for new minecraft commands PaperMC/Paper@d0ca1ba5 Not totally fixed LegacyTest PaperMC/Paper@c056e855 Fix some tests PaperMC/Paper@25c19061 Disable more recipe tests PaperMC/Paper@0f759961 Add PlayerOpenSignEvent.Cause for SignBlock PaperMC/Paper@283f4ca3 Add WAXED and CUSHION_COLOR Components PaperMC/Paper@d724d752 Add WAXED and CUSHION_COLOR Components (But now registered) PaperMC/Paper@d942ba00 Add MobVisibility item component PaperMC/Paper@a1c424c3 Minor changes into MobVisibility component PaperMC/Paper@d8a52974 Add VillagerFood component PaperMC/Paper@e63de766 Add SignText component PaperMC/Paper@3318f8bc Temp fix for missing components until proper API is added PaperMC/Paper@021644e9 pot PaperMC/Paper@5f599b9e Update dependencies to match Vanilla PaperMC/Paper@4bc49ac4 Update org.checkerframework:checker-qual and org.jetbrains:annotations PaperMC/Paper@cfbf9f14 Update JSpecify dependency to 1.0.1 PaperMC/Paper@a0c04746 Update JOML dependency to 1.10.9 PaperMC/Paper@837b4fff Revert "Update JSpecify dependency to 1.0.1" PaperMC/Paper@f918c497 Update to 26.3-pre-3 PaperMC/Paper@b746b8cf Fix Boat.Status enum rewriter PaperMC/Paper@a3b2cb16 Fix zombie fly when trampling after cancelling EntityInteractEvent PaperMC/Paper#14225 PaperMC/Paper@50018799 Assign BlockProjectileSource before dispenser projectiles spawn PaperMC/Paper#14201 PaperMC/Paper@d8b57e43 Revert "Fix Boat.Status enum rewriter" PaperMC/Paper@4f149ad4 Merge remote-tracking branch 'upstream/main' into dev/26.3 PaperMC/Paper@a4fd6405 Update oldPaperCommit to latest (post merge) PaperMC/Paper@dcf362de Update to 26.3-rc-1 PaperMC/Paper@a51ca2cf The README Update [ci/skip] PaperMC/Paper@dd6d7e0a Rework some time command diff PaperMC/Paper@6507eb18 Update to 26.3-rc-2 PaperMC/Paper@7e7a8734 update mache PaperMC/Paper@4d290b9c Some more todos PaperMC/Paper@6266ef09 first pass at components, skip checkstyle between generated comments PaperMC/Paper@bdab2992 implement new level events PaperMC/Paper@c5e94cc9 fix override for Cushion PaperMC/Paper@61992ee6 bump built-in datapack version PaperMC/Paper@89fe83d3 add back renamed tags PaperMC/Paper@7df5258c implement block data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this while implementing a feature in my fork that uses
moonrise$loadChunksAsyncwithChunkStatus.EMPTY.The method above didn't honor the chunk status I've passed in and always load chunks as
FULLlevel.This PR passes the requested chunk status to
scheduleChunkLoadinstead of the hard-codingChunkStatus.FULL.Currently Paper doesn't have callers that are passing levels lower than
FULL, so it looks more likely a future-proof fix.