Repository navigation
Conversation
Perseus
added a commit
to Perseus/iceberg-rust
that referenced
this pull request
Oct 30, 2026
… ledger with_column_stats' doc promised rejection of ambiguous case-insensitive names, which needs apache#3070 (not in this base). It now says names resolve as select does. DFD_FORK.md links the DFD PR as the user of apache#3424 and explains the branch links in earlier Needed-by trailers. Upstream-PR: apache#3424 Upstream-head: 86e35d3 Backport-notes: doc wording differs from upstream; see DFD_FORK.md entry 3 Needed-by: Perseus/datafusion-distributed#7 Remove-when: the pinned iceberg-rust rev contains apache#3424's merge commit
Perseus
added a commit
to Perseus/iceberg-rust
that referenced
this pull request
Oct 31, 2026
… ledger with_column_stats' doc promised rejection of ambiguous case-insensitive names, which needs apache#3070 (not in this base). It now says names resolve as select does. DFD_FORK.md links the DFD PR as the user of apache#3424 and explains the branch links in earlier Needed-by trailers. Upstream-PR: apache#3424 Upstream-head: 86e35d3 Backport-notes: doc wording differs from upstream; see DFD_FORK.md entry 3 Needed-by: Perseus/datafusion-distributed#7 Remove-when: the pinned iceberg-rust rev contains apache#3424's merge commit
Perseus
added a commit
to Perseus/iceberg-rust
that referenced
this pull request
Oct 31, 2026
The fork maintainer's commits on this branch were re-made with the Perseus noreply identity. Trees and messages are unchanged. Update the ledger's fork SHAs and add a History section with the old -> new table. Upstream-PR: none Upstream-commit: none Backport-notes: none Needed-by: Perseus/datafusion-distributed#5, Perseus/datafusion-distributed#7 Remove-when: never (fork bookkeeping)
…canTask Bumps the [patch] rev for iceberg, iceberg-property-macro and iceberg-storage-opendal to Perseus/iceberg-rust@dacdc376, which adds a backport of apache/iceberg-rust#3424 and the DFD_FORK.md change ledger. No Rust changes.
Perseus
force-pushed
the
iceberg-dyn-filter/f2-fork-column-stats
branch
from
October 31, 2026 00:26
5ddbca8 to
c772286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #6; review that first.
What and why
Upcoming changes need per-file column min/max on
FileScanTaskso whole files can be skipped. Upstream apache/iceberg-rust#3424 adds that (TableScanBuilder::with_column_stats(names)andFileScanTask::column_stats()), but it is not merged. This PR moves the root[patch]to a new fork head that carries it. There are no Rust changes in this repo, and nothing calls the new API yet. By default, tasks carry no stats unlesswith_column_statsis called.Fork change ledger
All fork changes are tracked in
DFD_FORK.mdon branchdfd/runtime-predicate-5b82ab9of Perseus/iceberg-rust. It is fork-only bookkeeping and is never to be upstreamed. For each change it records the fork and upstream SHAs, upstream status, backport notes, why DFD needs it, who uses it, and when to drop it. These changes were added on top as a fast-forward (cbfab28d..bd8a39b5). The branch was later re-made once, only to change the commit identity (see the History section inDFD_FORK.md), so SHAs from before that point are no longer on the branch.Base is apache rev
5b82ab99, the rev datafusion-iceberg pins, soFileScanTaskstays one shared type. The commits are:6ed9531b(existing): cherry-pick of feat(reader): support execution-time predicates in ArrowReader apache/iceberg-rust#3351, execution-time predicates inArrowReader.cbfab28d(existing): test-only.unwrap(), becauseFileScanTaskDeleteFile::builder().build()returnsResultat5b82ab99(fix(scan): validate deletion vector delete tasks apache/iceberg-rust#3145).acf73714: addsDFD_FORK.md, including entries for the two commits above.cfd8069b: backport of feat(scan): optionally retain column statistics on FileScanTask apache/iceberg-rust#3424 (head86e35d3d), built from the PR's net diff with the original author kept.dacdc376: the #3424 ledger entry.bd8a39b5: fixes thewith_column_statsdoc comment (it wrongly promised ambiguous-name rejection) and points the ledger'sNeeded-byat this PR. The earlier three commits' trailers link a branch because this PR did not exist yet. They were not amended at the time, to avoid rewriting history; the ledger records this.The fork branch was later re-made once with a different commit identity, so its commit SHAs changed; the contents are unchanged, and the new head
1ddce488(pinned here) only adds the old-to-new SHA table toDFD_FORK.md.Backport conflicts in
scan/mod.rsand how they were resolvedrequire_field_idis used without?, becauseresolve_field_idreturnsOptionon this base. Names resolve exactly asselectdoes here. One consequence: an ambiguous case-insensitive name picks a field instead of failing, since the ambiguity check from #3070 is not on this base. The two #3070 ambiguity tests are not carried.column_stats_namessits next to this base'ssnapshot_id(upstream now hassnapshot_selection, #3260).with_column_statsis added unchanged.Datum::promote_to(#3483) is inlined as the same int→long and float→double widening.Type::Primitive(..), theNestedFieldsignature before #3527, andSchemaRefis imported intest_utils.Consequences
[patch."https://github.com/apache/iceberg-rust"]section.DFD_FORK.md.Verification
cargo check -p iceberg --testsis clean.cargo test -p iceberg --lib -- scan:: arrow::readergives 237 passed, the 7column_statstests pass, and thewith_column_statsdoctest passes.Cargo.lockchanges only the threesourcelines.cargo tree -dshows a singleicebergcrate, from the fork at1ddce488.cargo fmt --allis clean, as is clippy ondatafusion-distributed-iceberg --all-targets.cargo test -p datafusion-distributed-icebergpasses,cargo test --features integration --test dynamic_filteringgives 18 passed, andcargo check --workspace --all-targets --lockedpasses.