Repository navigation
Draw room labels from bbox center when pos or name is missing - #15
Open
jonatanjacobsson wants to merge 1 commit into
Open
jonatanjacobsson wants to merge 1 commit into
jonatanjacobsson wants to merge 1 commit into
Conversation
Roborock, Dreame, and Viomi omit those fields, so labels never drew. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Room.point()uses explicitpos_x/pos_ywhen both are set; otherwise it returns the bounding-box center. A name is no longer required for a label position._draw_room_namesdrawsroom.namewhen present and falls back tostr(room.number). It still skips only whenpoint()isNone.Roborock, Dreame, and Viomi parsers omit
pos_*and/orname, soRoom.point()previously returnedNoneand room labels never appeared on generated maps. Dreame already sets names but still did not draw becausepoint()also requiredpos_x/pos_y.Test plan
pos_x/pos_ystill labels at the explicit positionMade with Cursor