Skip to content

API functionality to log items picked up/dropped - #506

Open
rand0m0User wants to merge 2 commits into
PlayPro:masterfrom
rand0m0User:master
Open

rand0m0User wants to merge 2 commits into
PlayPro:masterfrom
rand0m0User:master

Conversation

@rand0m0User

Copy link
Copy Markdown

No description provided.

note: 'player' is only ever used for the player's name within the entire code base, consider using plain strings instead.
unclear if the addition of 2 methods deserves its own API version bump
@stale

stale Bot commented Apr 10, 2024

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 10, 2024
@Intelli Intelli removed the stale label Apr 10, 2024
@stale

stale Bot commented Jun 11, 2024

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jun 11, 2024
@Intelli Intelli removed the stale label Jun 12, 2024
@stale

stale Bot commented Aug 11, 2024

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Aug 11, 2024
@Intelli Intelli removed the stale label Aug 11, 2024
@stale

stale Bot commented Oct 17, 2024

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Oct 17, 2024
@Intelli Intelli removed the stale label Oct 17, 2024
@stale

stale Bot commented Dec 18, 2024

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 18, 2024
@Intelli Intelli removed the stale label Dec 18, 2024
@stale

stale Bot commented Feb 16, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Feb 16, 2025
@Intelli Intelli removed the stale label Feb 16, 2025
@stale

stale Bot commented Apr 17, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 17, 2025
@Intelli Intelli removed the stale label Apr 17, 2025
@stale

stale Bot commented Jun 16, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jun 16, 2025
@Intelli Intelli removed the stale label Jun 16, 2025
@stale

stale Bot commented Aug 16, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Aug 16, 2025
@Intelli Intelli removed the stale label Aug 16, 2025
@stale

stale Bot commented Oct 15, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Oct 15, 2025
@Intelli Intelli removed the stale label Oct 15, 2025
@stale

stale Bot commented Dec 14, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 14, 2025
@Intelli Intelli removed the stale label Dec 14, 2025
@stale

stale Bot commented Feb 13, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Feb 13, 2026
@Intelli Intelli removed the stale label Feb 13, 2026
@stale

stale Bot commented Apr 17, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 17, 2026
@Intelli Intelli removed the stale label Apr 17, 2026
@stale

stale Bot commented Jun 26, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jun 26, 2026
@Intelli Intelli removed the stale label Jun 26, 2026
@stale

stale Bot commented Aug 25, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Aug 25, 2026
@Intelli Intelli removed the stale label Aug 25, 2026
@Intelli

Intelli commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Adding explicit drop and pickup logging to the API makes sense. Before merging, please update the PR against current master and address the following:

  • Add the missing imports for ItemStack and both listener classes.
  • Make pickup logging accept and preserve the supplied username directly, without resolving it through Bukkit.getPlayer(). The current implementation can throw for offline/custom users or attribute the transaction to a different matching player.
  • Return false when the relevant world logging setting prevents the request from being queued.
  • Fix the documentation examples, including the missing semicolons/commas, inconsistent API variable name, and null-player handling. Document the methods in the current API documentation with an accurate minimum supported version.
    Please reuse the existing transaction logging path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants