Skip to content

feat: add entities to /purge command - #807

Open
DereC4 wants to merge 2 commits into
PlayPro:masterfrom
Derec-Mods:master
Open

DereC4 wants to merge 2 commits into
PlayPro:masterfrom
Derec-Mods:master

Conversation

@DereC4

@DereC4 DereC4 commented Oct 21, 2025

Copy link
Copy Markdown

tried to keep as many things in place as possible, and used the entity ID utility functions from the class to map entity to their numeric ID

@stale

stale Bot commented Dec 20, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 20, 2025
@Intelli Intelli removed the stale label Dec 20, 2025
@agusmeroli

Copy link
Copy Markdown
Contributor

This would be a very welcome addition, however this PR doesn't actually do what it says. I have tested this, turns out that's not how the database schema is set up unfortunately, it just throws SQLITE errors if an entity id is provided.

@stale

stale Bot commented Apr 11, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 11, 2026
@Intelli Intelli removed the stale label Apr 11, 2026
@stale

stale Bot commented Jun 14, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jun 14, 2026
@Intelli Intelli removed the stale label Jun 15, 2026
@stale

stale Bot commented Aug 16, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Aug 16, 2026
@Intelli Intelli removed the stale label Aug 16, 2026
@Intelli

Intelli commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Entity-type filtering for purge would be a useful addition, but this implementation needs changes before merging.

  • Entity kills are stored in co_block (action=3, type=entity ID); co_entity contains linked metadata and has no type column. Please filter the actual entity event rows, distinguish entity actions from material actions, and handle linked metadata safely.
  • There are also regressions: unfiltered global SQLite purges retain all block/entity rows; block-filtered global SQLite purges remove unrelated history; entity-only MySQL purges ignore the entity restriction; and world-scoped SQLite entity purges remove unrelated block history.
  • Please rebase onto the current purge implementation and apply entity filtering consistently across supported backends, preserving existing unfiltered, block-filtered, world and time-range behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants