Example validation: Fails if a parameter has a ValidateSet #242

Copy link

Copy link

Open

Open

Example validation: Fails if a parameter has a ValidateSet#242

Copy link

Labels

enhancementThe issue is an enhancement request.The issue is an enhancement request.help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.

Description

Johan Ljunggren (johlju)

opened on Jul 1, 2018

Issue body actions

The following code does not take in account if there are a validate set on a mandatory parameter.
Also, this code should be split out to a separate function.

DscResource.Tests/Meta.Tests.ps1

Lines 697 to 710 in 7956b15

	<#
	Check for mandatory parameters.
	Assume the parameters are all in the 'all' parameter set.
	#>
	$isParameterMandatory = $exampleCommand.Parameters[$parameterName].ParameterSets['__AllParameterSets'].IsMandatory
	if ($isParameterMandatory)
	{
	<#
	Convert '1' to the type that the parameter expects.
	Using '1' since it can be converted to String, Numeric
	and Boolean.
	#>
	$exampleParameters.Add($parameterName, ('1' -as $parameterType))
	}

Activity

1. Johan Ljunggren (johlju)

   added

   enhancementThe issue is an enhancement request.The issue is an enhancement request.

   help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.

   on Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

Labels

enhancementThe issue is an enhancement request.The issue is an enhancement request.help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

• Open in GitHub Copilot app