Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

When opt-in to spell-check, the cloned DscResource.Tests is also spell-checked #312

Open

Description

Details of the problem, bug, or enhancement

If a resource module has opt-in to use spell-check to spell-check is also testing markdown files inside DscResource.Tests.

Verbose logs showing the problem (if applicable)

https://ci.appveyor.com/project/johlju/dscresource-template/builds/22770345#L373

      [-] Should not have spelling errors in any markdown files 2.04s
        Expected 0, but got 1.
        1130:             $process.ExitCode | Should -Be 0
        at <ScriptBlock>, C:\projects\DscResource.Template\DscResource.Tests\Meta.Tests.ps1: line 1130
There were spelling errors. If these are false negatives, then please add the
word or phrase to the settings file '/.vscode/cSpell.json' in the repository.
See this section for more information.
https://github.com/PowerShell/DscResource.Tests/#common-tests-spellcheck-markdownfiles
CODE_OF_CONDUCT.md:5:13 - Unknown word (opencode)
CODE_OF_CONDUCT.md:5:44 - Unknown word (opencode)
DscResource.Tests/CHANGELOG.md:8:93 - Unknown word (Nuget)
DscResource.Tests/CHANGELOG.md:11:31 - Unknown word (PSPKI)
DscResource.Tests/CHANGELOG.md:15:10 - Unknown word (gitignore)
DscResource.Tests/CHANGELOG.md:29:10 - Unknown word (PSSA)
DscResource.Tests/CHANGELOG.md:136:20 - Unknown word (HKLM)
DscResource.Tests/CHANGELOG.md:263:71 - Unknown word (Guids)
DscResource.Tests/CHANGELOG.md:275:11 - Unknown word (gitattributes)
DscResource.Tests/CHANGELOG.md:279:54 - Unknown word (EXTERNALMODULEDEPENDENCIES)
DscResource.Tests/CHANGELOG.md:280:33 - Unknown word (EXTERNALMODULEDEPENDENCIES)
DscResource.Tests/CHANGELOG.md:305:50 - Unknown word (unstaged)
DscResource.Tests/CHANGELOG.md:306:15 - Unknown word (gitattributes)
DscResource.Tests/CHANGELOG.md:350:5 - Unknown word (gitattributes)
DscResource.Tests/CHANGELOG.md:350:62 - Unknown word (autocrlf)
DscResource.Tests/README.md:7:13 - Unknown word (opencode)
DscResource.Tests/README.md:7:44 - Unknown word (opencode)
DscResource.Tests/README.md:43:31 - Unknown word (psscriptanalyzer)
DscResource.Tests/README.md:45:24 - Unknown word (metafixers)
DscResource.Tests/README.md:46:24 - Unknown word (testhelper)
DscResource.Tests/README.md:49:74 - Unknown word (dscresourcetests)
DscResource.Tests/README.md:54:45 - Unknown word (codecoverage)
DscResource.Tests/README.md:54:73 - Unknown word (codecovio)
DscResource.Tests/README.md:56:59 - Unknown word (codecovio)
DscResource.Tests/README.md:57:39 - Unknown word (codecovio)
DscResource.Tests/README.md:124:13 - Unknown word (vors)
DscResource.Tests/README.md:169:10 - Unknown word (opencode)
DscResource.Tests/README.md:170:13 - Unknown word (gitattributes)
DscResource.Tests/README.md:188:3 - Unknown word (gulpfile)
DscResource.Tests/README.md:238:128 - Unknown word (PSSA)
DscResource.Tests/README.md:239:25 - Unknown word (PSSA)
DscResource.Tests/README.md:243:50 - Unknown word (PSSA)
DscResource.Tests/README.md:247:80 - Unknown word (PSSA)
DscResource.Tests/README.md:261:31 - Unknown word (Dism)
DscResource.Tests/README.md:285:31 - Unknown word (Dism)
DscResource.Tests/README.md:507:24 - Unknown word (subfolders)
DscResource.Tests/README.md:543:29 - Unknown word (HQRM)
DscResource.Tests/README.md:624:14 - Unknown word (windowsservercore)
DscResource.Tests/README.md:665:3 - Unknown word (unittest)
DscResource.Tests/README.md:667:3 - Unknown word (unittest)
DscResource.Tests/README.md:669:3 - Unknown word (unittest)
DscResource.Tests/README.md:671:3 - Unknown word (unittest)
DscResource.Tests/README.md:751:64 - Unknown word (autocrlf)
DscResource.Tests/README.md:755:33 - Unknown word (gitattributes)
DscResource.Tests/README.md:782:19 - Unknown word (PRIVATEDATA)
DscResource.Tests/README.md:790:2 - Unknown word (COMPANYNAME)
DscResource.Tests/README.md:793:2 - Unknown word (LICENSEURI)
DscResource.Tests/README.md:794:2 - Unknown word (PROJECTURI)
DscResource.Tests/README.md:795:2 - Unknown word (ICONURI)
DscResource.Tests/README.md:796:2 - Unknown word (EXTERNALMODULEDEPENDENCIES)
DscResource.Tests/README.md:797:2 - Unknown word (REQUIREDSCRIPTS)
DscResource.Tests/README.md:798:2 - Unknown word (EXTERNALSCRIPTDEPENDENCIES)
DscResource.Tests/README.md:799:2 - Unknown word (RELEASENOTES)
DscResource.Tests/README.md:800:2 - Unknown word (PRIVATEDATA)
DscResource.Tests/README.md:800:19 - Unknown word (Datacenter)
DscResource.Tests/README.md:800:35 - Unknown word (Datacenter)
    Context When uninstalling spellcheck dependencies

Suggested solution to the issue

Exclude the DscResource.Tests folder when spell-checking a resource module.

Activity

  1. changed the title [-]When opt-in to spell-check the cloned DscResource.Tests is also spell-checked[/-] [+]When opt-in to spell-check, the cloned DscResource.Tests is also spell-checked[/+] on May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions